Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error when --preprocess or --show-properties were passed #331

Merged
merged 3 commits into from
Aug 9, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Aug 8, 2019

The command should exit early when --preprocess or --show-properties are passed, since binary artifacts are not produced and command would fail.

EDIT: Now that #337 was merged, this PR fixes #333

@masci masci force-pushed the massi/preprocess branch from 07597c5 to 4b499db Compare August 9, 2019 14:51
@masci masci removed the status: in progress Work is in progress on this label Aug 9, 2019
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit d81cbbf into master Aug 9, 2019
@masci masci deleted the massi/preprocess branch August 9, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output of compile --preprocess is different from the file generated with the Arduino app
2 participants