Skip to content

Commit

Permalink
Fix autoupdate bundle (#853)
Browse files Browse the repository at this point in the history
* remove `--keepParent`, it's breaking the autoupdate bundle.
This flag was introduced by mistake, inside gon only `-c -k` were used
https://github.com/mitchellh/gon/blob/2d4f161ccecd1aae878f4416d5ccd622b1b01fdb/package/zip/zip.go#L59

* Revert "remove top level dir it's already there thanks to `ditto --keepParent"

This reverts commit 134d250.
  • Loading branch information
umbynos committed Nov 7, 2023
1 parent 35a05dc commit 3ba51ce
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ jobs:
run: gon -log-level=debug -log-json "${{ env.GON_CONFIG_PATH }}"

- name: Zip output app bundle
run: ditto -c -k --keepParent ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
run: ditto -c -k ArduinoCreateAgent.app/ ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip

- name: Remove gon used for code signing
run: |
Expand Down Expand Up @@ -455,10 +455,13 @@ jobs:
uses: actions/download-artifact@v3
with:
name: ArduinoCreateAgent.app_${{ matrix.arch }}_notarized
path: ArduinoCreateAgent.app

- name: unzip artifact
working-directory: ArduinoCreateAgent.app
run: |
unzip ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
rm ArduinoCreateAgent.app_${{ matrix.arch }}_notarized.zip
- name: Install create-dmg
run: brew install create-dmg
Expand Down

0 comments on commit 3ba51ce

Please sign in to comment.