Manage the HTTPS certificate from the menu and ask Safari users to install it at startup #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #941 +/- ##
==========================================
- Coverage 21.42% 20.72% -0.71%
==========================================
Files 42 42
Lines 2506 2591 +85
==========================================
Hits 537 537
- Misses 1872 1957 +85
Partials 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MatteoPologruto
force-pushed
the
check-valid-certificate
branch
12 times, most recently
from
2b8b5d4
to
b3aa9ab
Compare
MatteoPologruto
force-pushed
the
check-valid-certificate
branch
14 times, most recently
from
4bbef3c
to
8a020e9
Compare
Xayton
reviewed
May 8, 2024
MatteoPologruto
force-pushed
the
check-valid-certificate
branch
from
618f727
to
5678cbb
Compare
Xayton
approved these changes
May 8, 2024
This was
linked to
issues
May 8, 2024
…re outdated when the Agent is started
…ig is set to true
MatteoPologruto
force-pushed
the
check-valid-certificate
branch
from
3487304
to
27d8b76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Infrastructure enhancement
Safari users are prompted at startup to install the HTTPS certificate and their preference is saved in the
configfile.It is now possible to obtain the certificate informations (installed, trusted and expiration date) from the Agent menu before performing any action on the keychain.
If the installed certificate is expiring in less than one month, the Agent will ask the user to update it.
No