Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons and improve handling of certificates when Safari is not the default browser #949

Merged
merged 19 commits into from
May 13, 2024

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented May 8, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Bug fix

  • What is the current behavior?

"Manage HTTPS certificate" buttons do not work correctly and some cases in which the user's default browser is not Safari are poorly handled.

  • What is the new behavior?

The above mentioned behavior is fixed.

  • Does this PR introduce a breaking change?

No

  • Other information:

@MatteoPologruto MatteoPologruto self-assigned this May 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 73 lines in your changes are missing coverage. Please review.

Project coverage is 20.66%. Comparing base (222a505) to head (c461c40).

Files Patch % Lines
main.go 0.00% 39 Missing ⚠️
systray/systray_real.go 0.00% 24 Missing ⚠️
certificates/install_default.go 0.00% 5 Missing ⚠️
utilities/utilities.go 0.00% 3 Missing ⚠️
certificates/certificates.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
- Coverage   20.71%   20.66%   -0.06%     
==========================================
  Files          42       42              
  Lines        2592     2599       +7     
==========================================
  Hits          537      537              
- Misses       1958     1965       +7     
  Partials       97       97              
Flag Coverage Δ
unit 20.66% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoPologruto MatteoPologruto added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels May 8, 2024
@MatteoPologruto MatteoPologruto marked this pull request as ready for review May 8, 2024 15:07
@MatteoPologruto MatteoPologruto merged commit 3190a1a into arduino:main May 13, 2024
20 checks passed
@MatteoPologruto MatteoPologruto deleted the fix-buttons branch May 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants