Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message to the user after a successful certificate installation #951

Merged
merged 2 commits into from
May 15, 2024

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented May 14, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Enhancement

  • What is the new behavior?

A message with infos on the certificate is shown to the user after a successful installation.

  • Does this PR introduce a breaking change?

No

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels May 14, 2024
@MatteoPologruto MatteoPologruto self-assigned this May 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 20.60%. Comparing base (3190a1a) to head (4cf2b6f).

Files Patch % Lines
certificates/certificates.go 0.00% 5 Missing ⚠️
systray/systray_real.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
- Coverage   20.66%   20.60%   -0.06%     
==========================================
  Files          42       42              
  Lines        2599     2606       +7     
==========================================
  Hits          537      537              
- Misses       1965     1972       +7     
  Partials       97       97              
Flag Coverage Δ
unit 20.60% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoPologruto MatteoPologruto marked this pull request as ready for review May 14, 2024 15:56
@MatteoPologruto MatteoPologruto merged commit 2fa738f into arduino:main May 15, 2024
20 checks passed
@MatteoPologruto MatteoPologruto deleted the show-info-after-install branch May 15, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants