-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if a signed URL is specified and use it download tools #953
Merged
MatteoPologruto
merged 5 commits into
arduino:main
from
MatteoPologruto:install-tools-code-dup
Jul 2, 2024
Merged
Check if a signed URL is specified and use it download tools #953
MatteoPologruto
merged 5 commits into
arduino:main
from
MatteoPologruto:install-tools-code-dup
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #953 +/- ##
==========================================
- Coverage 20.64% 20.10% -0.55%
==========================================
Files 42 42
Lines 2601 2537 -64
==========================================
- Hits 537 510 -27
+ Misses 1967 1943 -24
+ Partials 97 84 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d5560fc
to
4264332
Compare
umbynos
reviewed
May 23, 2024
umbynos
approved these changes
May 23, 2024
f61f4d1
to
f7f5a19
Compare
afe92ea
to
18e9250
Compare
umbynos
reviewed
Jun 21, 2024
umbynos
approved these changes
Jun 21, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Code enhancement
There are two ways of dowloading tools: Download and Install. The first one downloads and installs the tools from the package index only, while it is possible to provide a signed URL and a checksum to the second one to download a tool from there.
Download
is wrapped insideDownloadFromURL
to align it toInstall
.No