fix(regression): restore the Unknown board label

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
arduino · Aug 18, 2023 · b3b731a · b3b731a
1 parent 530cddb
commit b3b731a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/arduino-ide-extension/src/common/protocol/board-list.ts b/arduino-ide-extension/src/common/protocol/board-list.ts
@@ -1,4 +1,5 @@
 import type { Mutable } from '@theia/core/lib/common/types';
+import { Unknown } from '../nls';
 import type { Defined } from '../types';
 import { naturalCompare } from '../utils';
 import {
@@ -18,7 +19,6 @@ import {
   portProtocolComparator,
   selectBoard,
   unconfirmedBoard,
-  unknownBoard,
   notConnected,
   boardIdentifierLabel,
 } from './boards-service';
@@ -326,7 +326,7 @@ function createBoardListItemLabels(item: BoardListItem): BoardListItemLabels {
       unconfirmedBoard;
     board = { name, fqbn: undefined };
   }
-  const boardLabel = board?.name ?? unknownBoard;
+  const boardLabel = board?.name ?? Unknown;
   let boardLabelWithFqbn = boardLabel;
   if (board?.fqbn) {
     boardLabelWithFqbn += ` (${board.fqbn})`;

diff --git a/arduino-ide-extension/src/test/common/board-list.test.ts b/arduino-ide-extension/src/test/common/board-list.test.ts
@@ -1,4 +1,5 @@
 import { expect } from 'chai';
+import { Unknown } from '../../common/nls';
 import {
   BoardListLabels,
   createBoardList,
@@ -322,6 +323,11 @@ describe('board-list', () => {
       expect(inferredBoard?.board).to.be.deep.equal(uno);
     });
 
+    it(`should use the '${Unknown}' as the board label when no boards were discovered on a detected port`, () => {
+      const { items } = createBoardList({ ...detectedPort(unoSerialPort) });
+      expect(items[0].labels.boardLabel).to.be.equal(Unknown);
+    });
+
     describe('defaultAction', () => {
       it("'select' should be the default action for identifier boards", () => {
         const { items } = createBoardList({