-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the serial monitor view with a monaco editor #105
Comments
Originally posted by @eclipse1985 here:
|
Workaround for selected text becoming unselected on Arduino IDE 2.0.0-Beta.9, Mac OSX Big Sur, Version 11.4 Ctrl-C copy (Command-C on Mac) works correctly if the reset button on the client board is pressed and held while selecting text and copying to clipboard. Do not disconnect or remove power to the board or the whole serial monitor window will be cleared. I suspect this is because any serial output from the board causes a redraw of the Serial Monitor window, which in turn clears the selection before it can be copied. |
Please be careful to consider performance impact. Arduino 1.8 uses a lightweight editor (jTextArea). Even just supporting USB1 speed required a lot of work. When data arrives at sustained USB2 speed, its memory & CPU usage quickly spirals out of control, crashing the whole IDE on Windows and freezing the GUI on Linux. A couple years ago I poured a lot of work into improving the performance. Ultimately the problem is data management algorithms designed to support the arbitrary changes a text editor needs can end up performing very badly when used as a FIFO for high speed data. |
All we need is a timestamp, a pause button, a search field and a way to copy to the clipboard. KISS |
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Notes (for me) on why there is an undesired empty line in the output. Follow-up of: #391 (comment)
unsigned long previousMillis;
void setup() {
Serial.begin(9600);
}
void loop() {
if (Serial.available() > 0) {
while (Serial.available() > 0) {
Serial.write(Serial.read());
delay(10);
}
} else if (millis() - previousMillis >= 1000) {
previousMillis = millis();
int r = random(10);
if (r % 2 == 0) {
Serial.print("mega");
}
Serial.println("bug");
}
} Monitor output:
gRPC log:
Complete gRPC log + programmatically encoded
|
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Upstream microsoft/vscode#142933 |
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Closes arduino#105 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
monaco-editor
: https://github.com/Microsoft/monaco-editorThis is exactly the same task we did for the Output view in Theia: eclipse-theia/theia#7570
monaco.editor.ITextModel
. The logic that handles the UI update would be exactly the same as in VS Code; it's not that bad 😄Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: