-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate event listeners when zooming in/out with settings json editor open #1062
Closed
3 tasks done
Labels
conclusion: resolved
Issue was resolved
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
Comments
kittaakos
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
labels
Jun 14, 2022
kittaakos
pushed a commit
that referenced
this issue
Jul 25, 2022
Do not create a new instance per preferences transaction. Closes #1062 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
pushed a commit
that referenced
this issue
Jul 26, 2022
Do not create a new instance per preferences transaction. Closes #1062 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
pushed a commit
that referenced
this issue
Jul 27, 2022
preferences transaction. Closes #1062 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
pushed a commit
that referenced
this issue
Jul 27, 2022
preferences transaction. Closes #1062 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
pushed a commit
that referenced
this issue
Jul 27, 2022
- Debounced the connectivity status update. - Silent the output channel for the Arduino LS. - Delay the problem markers update with 500ms. - Do not update the status bar on every `keypress` event. - Debounced the tab-bar toolbar updates when typing in editor. - Fixed electron menu contribution binding. - Aligned the editor widget factory's API to Theia. - Set the zoom level when the app is ready (Closes #1244) - Fixed event listener leak (Closes #1062) Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
4 tasks
kittaakos
pushed a commit
that referenced
this issue
Jul 27, 2022
- Debounced the connectivity status update. - Silent the output channel for the Arduino LS. - Delay the problem markers update with 500ms. - Do not update the status bar on every `keypress` event. - Debounced the tab-bar toolbar updates when typing in editor. - Fixed electron menu contribution binding. - Aligned the editor widget factory's API to Theia. - Set the zoom level when the app is ready (Closes #1244) - Fixed event listener leak (Closes #1062) Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
pushed a commit
that referenced
this issue
Jul 28, 2022
- Debounced the connectivity status update. - Silent the output channel for the Arduino LS. - Delay the problem markers update with 500ms. - Do not update the status bar on every `keypress` event. - Debounced the tab-bar toolbar updates when typing in editor. - Fixed electron menu contribution binding. - Aligned the editor widget factory's API to Theia. - Set the zoom level when the app is ready (Closes #1244) - Fixed event listener leak (Closes #1062) Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
pushed a commit
that referenced
this issue
Aug 1, 2022
- Debounced the connectivity status update. - Silent the output channel for the Arduino LS. - Delay the problem markers update with 500ms. - Do not update the status bar on every `keypress` event. - Debounced the tab-bar toolbar updates when typing in editor. - Fixed electron menu contribution binding. - Aligned the editor widget factory's API to Theia. - Set the zoom level when the app is ready (Closes #1244) - Fixed event listener leak (Closes #1062) Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conclusion: resolved
Issue was resolved
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
Describe the problem
I am seeing warnings related to the increasing number of event listeners. I could reproduce it with RC7.
To reproduce
Expected behavior
Event listeners do not leak.
Arduino IDE version
rc7
Operating system
macOS
Operating system version
12.3.1
Additional context
No response
Issue checklist
The text was updated successfully, but these errors were encountered: