Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only package indexes should updated after changing the "Additional Boards Manager URL" preference. #1156

Closed
3 tasks done
kittaakos opened this issue Jul 8, 2022 · 0 comments · Fixed by #1418
Closed
3 tasks done
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Jul 8, 2022

Describe the problem

Originally reported here:

I notice that the Library Manager index is updated along with the package indexes after a change to the "Additional Boards Manager URLs" preference.

It seems a bit arbitrary to me since there is no reason to think a change to this Boards Manager-specific preference is an indication that the user is planning to use Library Manager.

I think that, for most users, just having a single library index update on startup will be sufficient. That might be problematic if a user leaves the IDE open permanently, but I think that would be a very rare usage pattern. Perhaps a periodic update of all indexes could be implemented at some point as part of the updatable platform and library notification system.

To reproduce

  1. Select File > Preferences from the Arduino IDE menus.
  2. Change the "Additional Boards Manager URL" preference by either adding or removing URLs.
  3. Click the OK button.
  4. Watch the index download notifications. They include "Downloading index: library_index.json.gz".

From the gRPC logs, it appears that a cc.arduino.cli.commands.v1.ArduinoCoreService/UpdateLibrariesIndex request is being sent in addition to the expected UpdateIndex for the package indexes.

daemon INFO 25 CALLED: /cc.arduino.cli.commands.v1.ArduinoCoreService/UpdateIndex STREAM_RESP
26 CALLED: /cc.arduino.cli.commands.v1.ArduinoCoreService/UpdateLibrariesIndex STREAM_RESP

Expected behavior

Only package indexes are updated after changing the "Additional Boards Manager URLs" preference.

Arduino IDE version

HEAD of the main

Operating system

macOS

Operating system version

12.3.1

Additional context

2.0.0-rc8-snapshot-24cc9f1 (tester build for a2bec12)

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jul 8, 2022
@kittaakos kittaakos self-assigned this Jul 8, 2022
@kittaakos kittaakos changed the title IDE2 should not update the library package index on 3rd part URLs change Only package indexes should updated after changing the "Additional Boards Manager URL" preference. Jul 8, 2022
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this issue Sep 28, 2022
 - IDE2 can start if the package index download fails. Closes arduino#1084
 - Split the lib and platform index update. Closes arduino#1156

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this issue Sep 29, 2022
 - IDE2 can start if the package index download fails. Closes arduino#1084
 - Split the lib and platform index update. Closes arduino#1156

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this issue Oct 4, 2022
 - IDE2 can start if the package index download fails. Closes arduino#1084
 - Split the lib and platform index update. Closes arduino#1156

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants