Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output panel should open immediately at press of "verify" or "upload" #1175

Closed
3 tasks done
ubidefeo opened this issue Jul 12, 2022 · 1 comment · Fixed by #1260
Closed
3 tasks done

Output panel should open immediately at press of "verify" or "upload" #1175

ubidefeo opened this issue Jul 12, 2022 · 1 comment · Fixed by #1260
Assignees
Labels
conclusion: resolved Issue was resolved criticality: medium Of moderate impact topic: code Related to content of the project itself type: enhancement Proposed improvement

Comments

@ubidefeo
Copy link

Describe the request

Modify the behaviour of the output panel upon "verify" or "upload" actions being triggered

As requested by @tigoe in #279 we should better communicate to the user the following as bare minimum:

  • something is happening
  • what is happening
    • verify start
    • verify success
    • upload start
    • upload success
  • interleave these messages to the tools' standard output we'd see when "verbose" is on

Describe the current behavior

The behaviour of the output panel differs from IDE 1.x as it won't open immediately at begin of "verify" or "upload" actions.
When compile/upload verbose is disabled, especially since the buttons are disabled at click, this can create the impression that nothing is happening until successful compilation (or error) output needs to be displayed triggering the opening of the output panel.

Arduino IDE version

2.0 (all)

Operating system

N/A

Operating system version

n/a

Additional context

No response

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@ubidefeo ubidefeo added type: enhancement Proposed improvement criticality: medium Of moderate impact labels Jul 12, 2022
@per1234 per1234 removed their assignment Jul 13, 2022
@per1234 per1234 added the topic: code Related to content of the project itself label Jul 13, 2022
@kittaakos
Copy link
Contributor

kittaakos commented Jul 15, 2022

  • something is happening

  • what is happening

    • verify start
    • verify success
    • upload start
    • upload success

We agreed on the followings:

  • IDE2 does not add additional content to the Output (such as verify started, upload completed, etc. messages) but uses the out_stream and err_stream from the CLI as they are (see: CompileResponse, UploadResponse, UploadUsingProgrammerResponse, and BurnBootloaderResponse),
  • For the verify and compile commands, IDE2 will support progress indication as part of Show 'progress' indicator during verify/upload #575.

@kittaakos kittaakos assigned kittaakos and unassigned AlbyIanna Jul 27, 2022
kittaakos pushed a commit that referenced this issue Jul 28, 2022
Closes #575
Closes #1175

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Jul 28, 2022
Closes #575
Closes #1175

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Jul 28, 2022
Closes #575
Closes #1175

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Jul 28, 2022
Closes #575
Closes #1175

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Aug 1, 2022
Closes #575
Closes #1175

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved criticality: medium Of moderate impact topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants