Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dark theme] Text contrast for selected board in Firmware Updater needs fixing #1441

Closed
3 tasks done
ubidefeo opened this issue Sep 15, 2022 · 0 comments · Fixed by #1465
Closed
3 tasks done

[Dark theme] Text contrast for selected board in Firmware Updater needs fixing #1441

ubidefeo opened this issue Sep 15, 2022 · 0 comments · Fixed by #1465
Assignees
@91volt @francescospissu
Labels
conclusion: resolved Issue was resolved topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project

Comments

@ubidefeo
Copy link

Describe the problem

The Dark Theme has a contrast issue in the Firmware Updater dialog.

see screenshots

no board connected
CleanShot 2022-09-15 at 09 58 27@2x

board connected and selectable
CleanShot 2022-09-15 at 09 58 42@2x

board selector open
CleanShot 2022-09-15 at 09 58 52@2x

board selected and menu closed
CleanShot 2022-09-15 at 09 59 02@2x

To reproduce

see screeshots above

Expected behavior

the contrast if better defined in the colour scheme

Arduino IDE version

2.0

Operating system

N/A

Operating system version

n/a

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@ubidefeo ubidefeo added the type: imperfection Perceived defect in any part of project label Sep 15, 2022
@kittaakos kittaakos added the topic: theme Related to GUI theming label Sep 16, 2022
@francescospissu francescospissu mentioned this issue Sep 19, 2022
Merged
4 tasks
francescospissu added a commit that referenced this issue Sep 20, 2022
@francescospissu
Fix input background in Firmware Updater dialog (#1465)
b3ab5cb 
Closes #1441.
@per1234 per1234 added the conclusion: resolved Issue was resolved label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@91volt 91volt

@francescospissu francescospissu

Labels
conclusion: resolved Issue was resolved topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1441 Fix input background in Firmware Updater dialog arduino/arduino-ide
5 participants
@kittaakos @ubidefeo @per1234 @91volt @francescospissu