Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Manager version menu selection changes if user closes dependencies installation dialog #1707

Closed
3 tasks done
Tracked by #1927
per1234 opened this issue Nov 25, 2022 · 0 comments · Fixed by #1927
Closed
3 tasks done
Tracked by #1927
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Nov 25, 2022

Describe the problem

An Arduino library can specify dependencies on other libraries via its metadata. When the user installs a library with defined dependencies via Library Manager, Arduino IDE shows a dialog that offers to install these dependencies along with the library.

image

If the user closes that dialog, the selection in the version menu changes:

  • If the latest version is currently selected, the previous version is selected
  • If a previous version is currently selected, the latest version is selected

🐛 The user will likely not notice this unexpected change. If they trigger an install operation on the library once more, they will install a different version than they intended.

If the version the IDE attempts to switch the menu to is currently installed, the current selection is retained, but an install operation will attempt to install the version it attempted to switch the menu to.

🐛 The user will be confused when the installation operation fails due to attempting to install a different version than was already selected.

To reproduce

  1. Find the "ArduinoModbus" library in the Library Manager view.
  2. If the library is already installed, uninstall it.
  3. Take note of the selection in the version menu (e.g., "1.0.7")
  4. Click the INSTALL button.
  5. Click the X icon on the "Install library dependencies" dialog.
    🐛 The selection in the version menu changed.
  6. Select the version of the library before the latest version from the menu (e.g., if the latest version is 1.0.7, select "1.0.6" from the menu).
  7. Click the INSTALL button and install the library.
    🙂 The version menu selection changes to the latest version of the library.
  8. Click the INSTALL button.
  9. Click the X icon on the "Install library dependencies" dialog.
    🙂 The latest version of the library is still selected in the version menu.
  10. Click the INSTALL button and install the library.
    🐛 The version of the library selected from the version menu is not installed. The Output view shows that the install operation attempted to install the previous version:

    Already installed ArduinoModbus@1.0.6

Expected behavior

Version menu selection only changes after a successful installation.

Arduino IDE version

2.0.2

Operating system

Windows

Operating system version

10

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Nov 25, 2022
@kittaakos kittaakos self-assigned this Mar 2, 2023
kittaakos pushed a commit that referenced this issue Mar 7, 2023
Closes #19
Closes #781
Closes #1591
Closes #1607
Closes #1697
Closes #1707
Closes #1924

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Mar 7, 2023
Closes #19
Closes #781
Closes #1591
Closes #1607
Closes #1697
Closes #1707
Closes #1924
Closes #1941

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Mar 9, 2023
Closes #19
Closes #781
Closes #1591
Closes #1607
Closes #1697
Closes #1707
Closes #1924
Closes #1941

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Mar 9, 2023
Closes #19
Closes #781
Closes #1591
Closes #1607
Closes #1697
Closes #1707
Closes #1924
Closes #1941

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Mar 9, 2023
Closes #19
Closes #781
Closes #1591
Closes #1607
Closes #1697
Closes #1707
Closes #1924
Closes #1941

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Mar 13, 2023
Closes #19
Closes #781
Closes #1591
Closes #1607
Closes #1697
Closes #1707
Closes #1924
Closes #1941

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added the conclusion: resolved Issue was resolved label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants