Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE2's settings model gets out of sync from the persisted values of the Theia preferences #1987

Closed
3 tasks done
kittaakos opened this issue Mar 31, 2023 · 0 comments · Fixed by #1988
Closed
3 tasks done

IDE2's settings model gets out of sync from the persisted values of the Theia preferences #1987

kittaakos opened this issue Mar 31, 2023 · 0 comments · Fixed by #1988
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

Describe the problem

When I change the font size + interface scale settings with a keybinding and the theme from the command palette, the settings model gets out of sync.

To reproduce

  • Select a theme that is different from your currently selected one from the command palette with the Ctrl/⌘+K Ctrl/⌘+T key-chord. Confirm your selection with Enter—the theme changes.
  • Increase the font size with Ctrl/⌘+=. The font size changes, but the theme reverts to the previous one.
settings_out_of_sync.mp4

Another use-case:

  • Open settings dialog,
  • Change the theme with the command palette,
  • The theme <select> does not change in the dialog,
  • Press OK or Cancel, the theme reverts.
settings_dialog_out_of_sync_01.mp4
settings_dialog_out_of_sync_02.mp4

Expected behavior

The IDE2's settings model is in sync with the Theia preferences:

  • After changing the theme from the command palette, changing the interface scale via the keyboard does not revert the theme change.
  • When the settings dialog is opened, the theme <select> reflects the current IDE2 theme:
    • Pressing Cancel reverts to the theme which was active before opening the settings dialog,
    • Pressing OK keeps the selected theme.

Arduino IDE version

2.0.4

Operating system

macOS

Operating system version

12.6.3

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 31, 2023
kittaakos pushed a commit that referenced this issue Mar 31, 2023
fix: update themeId settings after theme change
a90a6c7 
In Theia, the theme ID is not always in sync with the persisted
`workbench.colorTheme` preference value. For example, one can preview a
theme with the `CtrlCmd+K` + `CtrlCmd+T` key chords. On quick pick
selection change events, the theme changes, but the change is persisted
only on accept (user presses `Enter`).

IDE2 has its own way of showing and managing different settings in the
UI. When the theme is changed from outside of the IDE2's UI, the model
could get out of sync. This PR ensures that on `workbench.colorTheme`
preference change, IDE2's settings model is synchronized with persisted
Theia preferences.

Closes #1987

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this issue Mar 31, 2023
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Apr 3, 2023
fix: update themeId settings after theme change
454802b 
In Theia, the theme ID is not always in sync with the persisted
`workbench.colorTheme` preference value. For example, one can preview a
theme with the `CtrlCmd+K` + `CtrlCmd+T` key chords. On quick pick
selection change events, the theme changes, but the change is persisted
only on accept (user presses `Enter`).

IDE2 has its own way of showing and managing different settings in the
UI. When the theme is changed from outside of the IDE2's UI, the model
could get out of sync. This PR ensures that on `workbench.colorTheme`
preference change, IDE2's settings model is synchronized with persisted
Theia preferences.

Closes #1987

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Apr 4, 2023
fix: update themeId settings after theme change
cd43a75 
In Theia, the theme ID is not always in sync with the persisted
`workbench.colorTheme` preference value. For example, one can preview a
theme with the `CtrlCmd+K` + `CtrlCmd+T` key chords. On quick pick
selection change events, the theme changes, but the change is persisted
only on accept (user presses `Enter`).

IDE2 has its own way of showing and managing different settings in the
UI. When the theme is changed from outside of the IDE2's UI, the model
could get out of sync. This PR ensures that on `workbench.colorTheme`
preference change, IDE2's settings model is synchronized with persisted
Theia preferences.

Closes #1987

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos pushed a commit that referenced this issue Apr 13, 2023
fix: update themeId settings after theme change
a431456 
In Theia, the theme ID is not always in sync with the persisted
`workbench.colorTheme` preference value. For example, one can preview a
theme with the `CtrlCmd+K` + `CtrlCmd+T` key chords. On quick pick
selection change events, the theme changes, but the change is persisted
only on accept (user presses `Enter`).

IDE2 has its own way of showing and managing different settings in the
UI. When the theme is changed from outside of the IDE2's UI, the model
could get out of sync. This PR ensures that on `workbench.colorTheme`
preference change, IDE2's settings model is synchronized with persisted
Theia preferences.

Closes #1987

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the topic: theme Related to GUI theming label Apr 14, 2023
kittaakos pushed a commit that referenced this issue Apr 14, 2023
@kittaakos
fix: update themeId settings after theme change
cb2a371 
In Theia, the theme ID is not always in sync with the persisted
`workbench.colorTheme` preference value. For example, one can preview a
theme with the `CtrlCmd+K` + `CtrlCmd+T` key chords. On quick pick
selection change events, the theme changes, but the change is persisted
only on accept (user presses `Enter`).

IDE2 has its own way of showing and managing different settings in the
UI. When the theme is changed from outside of the IDE2's UI, the model
could get out of sync. This PR ensures that on `workbench.colorTheme`
preference change, IDE2's settings model is synchronized with persisted
Theia preferences.

Closes #1987

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: theme Related to GUI theming type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update themeId settings after theme change arduino/arduino-ide
2 participants
@kittaakos @per1234