Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start the CLI daemon process without a shell #2112

Closed
3 tasks done
kittaakos opened this issue Jun 23, 2023 · 0 comments · Fixed by #2182
Closed
3 tasks done

Start the CLI daemon process without a shell #2112

kittaakos opened this issue Jun 23, 2023 · 0 comments · Fixed by #2182
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: security Related to the protection of user data type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented Jun 23, 2023 •
edited by per1234
Loading

Describe the problem

This is a follow-up task of #2067:

The CLI daemon process is a leftover:

arduino-ide/arduino-ide-extension/src/node/arduino-daemon-impl.ts

Lines 174 to 175 in d79bc0d

const options = { shell: true };
const daemon = spawn(`"${cliPath}"`, args, options);

To reproduce

It's a dev thing.

Expected behavior

Processes are not started with a shell.

Arduino IDE version

d79bc0d

Operating system

macOS

Operating system version

13.4

Additional context

Related

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself topic: security Related to the protection of user data type: imperfection Perceived defect in any part of project labels Jun 23, 2023
@kittaakos kittaakos self-assigned this Jun 23, 2023
kittaakos pushed a commit that referenced this issue Aug 20, 2023
fix: execute the Arduino CLI without a shell
4398f66 
Closes #2112
Ref: #2067

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this issue Aug 20, 2023
Merged
4 tasks
kittaakos pushed a commit that referenced this issue Aug 20, 2023
@kittaakos
fix: execute the Arduino CLI without a shell
2aae9e0 
Closes #2112
Ref: #2067

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Aug 20, 2023
@per1234 per1234 mentioned this issue Sep 28, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: security Related to the protection of user data type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: execute the Arduino CLI without a shell arduino/arduino-ide
2 participants
@kittaakos @per1234