Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulled remote sketches don't show error underlines and markers #669

Closed
91volt opened this issue Dec 7, 2021 · 1 comment · Fixed by #2037
Closed

Pulled remote sketches don't show error underlines and markers #669

91volt opened this issue Dec 7, 2021 · 1 comment · Fixed by #2037
Assignees
Labels
conclusion: resolved Issue was resolved criticality: high Of high impact phase: implementation Work is in the implementation phase priority: medium Resolution is a medium priority topic: cloud Related to Arduino Cloud and cloud sketches topic: language server Related to the Arduino Language Server type: imperfection Perceived defect in any part of project

Comments

@91volt
Copy link

91volt commented Dec 7, 2021

Describe the bug
When working on a sketch pulled from the cloud the user doesn't get any error marker/underline in the code editor. It makes a lot difficult to debug and troubleshoot the remote sketch.

To Reproduce
Steps to reproduce the behavior:

  1. Go to web editor at https://create.arduino.cc/editor and Login
  2. Open blink example clicking the voice from left sidebar 'example' > '01. BASICS (6)' > 'blink.ino'
  3. Try to modify the sketch and when prompted by the dialog box save it as 'blink_test'
  4. Delete the last semicolon at line 36
  5. Open the IDE 2 software
  6. Go to sketchbook explorer clicking the first voice on left sidebar
  7. Open remote sketchbooks clicking on 🌐 tab in the sidebar
  8. Pull 'blink_test' clicking on down arrow icon on the right of the sketch's name
  9. Open the pulled sketch double clicking on 'blink_test' on the sidebar
  10. Try to verify -> it will give an error but no red underline at the end of line 36
  11. Save the sketch locally pressing CMD/Ctrl + Shift + S, save it in Arduino folder.
  12. Check line 36 and you will see the error underline where the semicolon is missing.

Expected behavior
I expect to see the same behaviour of local sketches: if an error is present in the code I expect it to be red underlined and a red marker to be present in the scrollbar area in the far right.

Screenshots
missing_cloud_errors

Desktop (please complete the following information):

  • OS: All
  • Version: 2.0.0 beta 12

Additional context
It seems not caused by a language server crash

@91volt 91volt added priority: medium Resolution is a medium priority type: imperfection Perceived defect in any part of project phase: implementation Work is in the implementation phase criticality: high Of high impact labels Dec 7, 2021
@per1234 per1234 added the topic: language server Related to the Arduino Language Server label Dec 7, 2021
@per1234
Copy link
Contributor

per1234 commented Jul 19, 2022

An update: as of #1107, the "problems" (AKA "diagnostics") feature this issue applies to is disabled by default. This means that the underlines would not be shown even if the feature was working correctly for remote sketches.

In order to reproduce the issue you must first enable the feature:

  1. Open the "Command Palette" (Ctrl/+Shift+P).
  2. Select the "Preferences: Open Settings (UI)" command from the "Command Palette".
    The "Preferences" tab will now open in the editor panel.
  3. In the "Search Settings" field, type arduino.language.realTimeDiagnostics
  4. Check the checkbox under the "Arduino › Language: Real Time Diagnostics" section if it is unchecked.

I expected that the bug would affect all language server features ("Go to definition", hover, suggest, parameter hints). But those seem to be working fine for remote sketches, so it seems the bug is specific to the "problems" feature.

@kittaakos kittaakos added the topic: cloud Related to Arduino Cloud and cloud sketches label Apr 13, 2023
kittaakos pushed a commit that referenced this issue Apr 28, 2023
PROEDITOR-50: error markers have been disabled for built-ins (daedae1).
Relaxed the error marker filtering for cloud sketches.

Closes #669

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos assigned kittaakos and unassigned fstasi Apr 28, 2023
@kittaakos kittaakos removed the topic: language server Related to the Arduino Language Server label Apr 28, 2023
kittaakos pushed a commit that referenced this issue May 5, 2023
PROEDITOR-50: error markers have been disabled for built-ins (daedae1).
Relaxed the error marker filtering for cloud sketches.

Closes #669

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added the conclusion: resolved Issue was resolved label May 5, 2023
@per1234 per1234 added the topic: language server Related to the Arduino Language Server label Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved criticality: high Of high impact phase: implementation Work is in the implementation phase priority: medium Resolution is a medium priority topic: cloud Related to Arduino Cloud and cloud sketches topic: language server Related to the Arduino Language Server type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants