Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken appStateService in the IDE #985

Closed
3 tasks done
kittaakos opened this issue May 11, 2022 · 1 comment · Fixed by #986
Closed
3 tasks done

Broken appStateService in the IDE #985

kittaakos opened this issue May 11, 2022 · 1 comment · Fixed by #986
Assignees
@kittaakos
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@kittaakos
Copy link
Contributor

kittaakos commented May 11, 2022 •
edited by per1234
Loading

Describe the problem

The FrontendApplicationStateService is a Theia service that can pause the execution logic and wait until a particular application state ('init', 'ready', etc.) is reached. Then, the IDE can perform various logic. The app state service throws an error at IDE startup.

To reproduce

Steps to reproduce:

  • Download the latest nightly,
  • Start the IDE,
  • Open DevTools (to see the error),
  • See the error.
Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'reachedState')
    at H.init (arduino-frontend-contribution.tsx:241)
Monosnap.screencast.2022-05-11.15-20-16.mp4

Expected behavior

The app state service does not throw an error and can be used to wait until a specific app state is reached.

Arduino IDE version

Version: 2.0.0-rc6-nightly-20220511

Operating system

macOS

Operating system version

12.3.1 (21E258)

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest nightly build
  • My report contains all necessary details
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels May 11, 2022
@kittaakos kittaakos self-assigned this May 11, 2022
kittaakos pushed a commit to kittaakos/arduino-ide that referenced this issue May 11, 2022
arduino#985: Restored the missing inject decorator.
082bf9f 
Closes arduino#985.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this issue May 11, 2022
Merged
4 tasks
@kittaakos
Copy link
Contributor Author

kittaakos commented May 11, 2022 •
edited by per1234
Loading

As noted in the PR, the broken injection has a side effect.

Steps to reproduce:

  • create a new sketch and save it to your local sketchbook,
  • open a terminal (can be from IDE too),
  • create a new .ino file from the terminal,
  • Expected: the new .ino file opens in a tab in the IDE,
  • delete the .ino from the terminal,
  • Expected: the deleted tab closes in the IDE.

kittaakos pushed a commit that referenced this issue May 13, 2022
@kittaakos
#985: Restored the missing inject decorator.
b407d0a 
Closes #985.

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added the conclusion: resolved Issue was resolved label May 13, 2022
@per1234 per1234 changed the title Broken appStateService in the IDE2 Broken appStateService in the IDE Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittaakos kittaakos

Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#985: Restored the missing inject decorator. kittaakos/arduino-ide
2 participants
@kittaakos @per1234