Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flush on clear output buffer #1074

Merged
merged 1 commit into from
Jun 20, 2022
Merged

flush on clear output buffer #1074

merged 1 commit into from
Jun 20, 2022

Conversation

davegarthsimpson
Copy link
Contributor

Motivation

Missing compilation output in output panel.

Change description

Make sure we flush all chunks of output from the CLI to the IDE.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@davegarthsimpson davegarthsimpson linked an issue Jun 17, 2022 that may be closed by this pull request
Last lines of compilation output are not printed #1073
Closed
3 tasks
@davegarthsimpson davegarthsimpson requested a review from per1234 June 17, 2022 22:22
per1234
per1234 approved these changes Jun 18, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #1073 for me.

Thanks Dave!

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 18, 2022
@davegarthsimpson davegarthsimpson merged commit a715da3 into main Jun 20, 2022
@davegarthsimpson davegarthsimpson deleted the 1073-last-lines-of-compilation-output-are-not-printed branch June 20, 2022 07:32
kittaakos pushed a commit that referenced this pull request Jun 21, 2022
Merged in #1074.
e7ee861 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos mentioned this pull request Jun 21, 2022
Merged
4 tasks
kittaakos pushed a commit that referenced this pull request Jun 21, 2022
@kittaakos
Merged in #1074.
4611381 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Last lines of compilation output are not printed
2 participants
@davegarthsimpson @per1234