remove state from stepper input and simplify

[davegarthsimpson]

Motivation

The settings-step-input.tsx component contains unnecessarily verbose code and inefficient logic.

Change description

Refactors the code, to exclude useState and useEffect hooks.

Acceptance Criteria

The stepper component should function exactly as before (prior to the changes in this PR).

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[kittaakos]

I assume the code could return with the function above 👆

if (eventValue === '') {
  setSettingsStateValue(0);
  return; // <---  this?
}

[davegarthsimpson]

yes! sorry I saw this after the fact, I'll add it in when we tackle the scale range question.

[kittaakos]

I tried it and it worked. Thank you!

[AlbyIanna]

The code looks fine to me overall, but I noticed a little bug.

It is possible, via shortcuts (CMD/CTRL + '+', CMD/CTRL + '-'), to exceed the min/max thresholds. For example, if the interface scale is set to 200 I can press CMD + '+' to increase the scale to 220. When the threshold is exceeded, the stepper buttons might look enabled even if they should be disabled.

Screen.Recording.2022-07-29.at.14.58.06.mov

[francescospissu]

Nice rework👍 I tested it by comparing the behavior with RC-9 and it works as before. I also found the bug reported by @AlbyIanna but it was already present before these changes.

[davegarthsimpson]

The code looks fine to me overall, but I noticed a little bug.

It is possible, via shortcuts (CMD/CTRL + '+', CMD/CTRL + '-'), to exceed the min/max thresholds. For example, if the interface scale is set to 200 I can press CMD + '+' to increase the scale to 220. When the threshold is exceeded, the stepper buttons might look enabled even if they should be disabled.

Thanks for catching this, this is actually because at the app level we are not restricting scale, we are only doing it with the stepper. This brings about the UX question: do we want to have a max/min scale. Either way the stepper itself is separate to this issue.