#1278 Use FQBN instead of Board for the monitor ID.

[kittaakos]

Motivation

To fix the upload functionality in IDE2 when the monitor is running.

Change description

Use fqbn (string | undefined) type instead of the Board | undefined for the monitor ID when notifying MonitorService before/after executing the upload command.

Other information

Closes #1278

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[kittaakos]

Note that the proposed changes fix the upload when the monitor is running, however, I see such an error in the logs. I did some investigation, and the same error occurred with 2.0.0-rc8 and 2.0.0-rc9.

From the sources [c0c5556]:

monitor-service ERROR Error: 2 UNKNOWN: Port monitor error: command 'open' failed: no such file or directory
    at Object.callErrorFromStatus (/Users/a.kitta/dev/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (/Users/a.kitta/dev/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/client.js:409:49)
    at Object.onReceiveStatus (/Users/a.kitta/dev/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:328:181)
    at /Users/a.kitta/dev/git/arduino-ide/node_modules/@grpc/grpc-js/build/src/call-stream.js:187:78
    at processTicksAndRejections (node:internal/process/task_queues:78:11)

rc-8:

root ERROR Error: 2 UNKNOWN: Port monitor error: command 'open' failed: no such file or directory
    at Object.callErrorFromStatus (/Users/a.kitta/Desktop/rc-8/Arduino IDE.app/Contents/Resources/app/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (/Users/a.kitta/Desktop/rc-8/Arduino IDE.app/Contents/Resources/app/node_modules/@grpc/grpc-js/build/src/client.js:409:49)
    at Object.onReceiveStatus (/Users/a.kitta/Desktop/rc-8/Arduino IDE.app/Contents/Resources/app/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:328:181)
    at /Users/a.kitta/Desktop/rc-8/Arduino IDE.app/Contents/Resources/app/node_modules/@grpc/grpc-js/build/src/call-stream.js:187:78
    at processTicksAndRejections (node:internal/process/task_queues:78:11)
root INFO monitor to /dev/cu.usbmodem14301 using serial closed by server

rc-9:

daemon INFO {"command":"QUIT","level":"info","monitor":"serial-monitor","msg":"sending command","time":"2022-08-03T09:17:49+02:00"}

daemon INFO {"level":"error","monitor":"serial-monitor","msg":"stopped decode loop: EOF","time":"2022-08-03T09:17:49+02:00"}

daemon INFO {"level":"info","monitor":"serial-monitor","msg":"Killing monitor process","time":"2022-08-03T09:17:49+02:00"}

daemon INFO {"level":"info","monitor":"serial-monitor","msg":"Monitor process killed","time":"2022-08-03T09:17:49+02:00"}

monitor-service ERROR Error: 2 UNKNOWN: Port monitor error: command 'open' failed: no such file or directory
    at Object.callErrorFromStatus (/Users/a.kitta/Desktop/rc-9/Arduino IDE.app/Contents/Resources/app/node_modules/@grpc/grpc-js/build/src/call.js:31:26)
    at Object.onReceiveStatus (/Users/a.kitta/Desktop/rc-9/Arduino IDE.app/Contents/Resources/app/node_modules/@grpc/grpc-js/build/src/client.js:409:49)
    at Object.onReceiveStatus (/Users/a.kitta/Desktop/rc-9/Arduino IDE.app/Contents/Resources/app/node_modules/@grpc/grpc-js/build/src/client-interceptors.js:328:181)
    at /Users/a.kitta/Desktop/rc-9/Arduino IDE.app/Contents/Resources/app/node_modules/@grpc/grpc-js/build/src/call-stream.js:187:78
    at processTicksAndRejections (node:internal/process/task_queues:78:11)
monitor-service INFO monitor to /dev/cu.usbmodem14301 using serial closed by server
daemon INFO {"level":"info","msg":"from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301","time":"2022-08-03T09:17:50+02:00"}

[francescospissu]

I tested it following the steps reported in #1278:

1. Connect an Arduino board to your computer.
2. Select the appropriate board and port in the Arduino IDE.
3. Open Serial Monitor in the Arduino IDE.
4. Select Sketch > Upload from the Arduino IDE menus.

Using 2.0.0-rc9.1 I cannot upload the sketch and I get this error:

No upload port found, using address:"COM6" label:"COM6" protocol:"serial" protocol_label:"Serial Port (USB)" as fallback
Failed uploading: uploading error: exit status 1No device found on COM6

With this fix I can upload the sketch on the board correctly.

[per1234]

This fixes #1278 for me. Thanks Akos!

Regarding the Port monitor error: command 'open' failed: no such file or directory error you mentioned, I am unfortunate in my fortune of not being able to reproduce it on my Windows and Linux machines.

Since you have it even with previous versions, I don't think it is of concern for this specific PR, but would be worth investigating eventually even if only for the sake of seeing whether a potentially confusing spurious error message could be prevented in some way.