Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial Monitor autoscroll only makes bottom line partially visible #972 #1446

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Serial Monitor autoscroll only makes bottom line partially visible #972 #1446

merged 2 commits into from
Sep 20, 2022

Conversation

dwightfowler-cd
Copy link
Contributor

@dwightfowler-cd dwightfowler-cd commented Sep 16, 2022

Motivation

A fix for Issue #972

Change description

Fixed margin of <pre></pre> tag used to display each line of text

Other information

N/A

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2022

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: serial monitor Related to the Serial Monitor labels Sep 16, 2022
@eried
Copy link

eried commented Sep 16, 2022

Please merge this.

image

@kittaakos kittaakos requested a review from AlbyIanna September 16, 2022 13:39
@dwightfowler-cd
Copy link
Contributor Author

Had a chance to sleep on it (literally), and I think modifying the <pre> style's margin setting in monitor.css is a much cleaner solution.

@per1234 per1234 linked an issue Sep 18, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me! Thank you so much for your contribution @dwightfowler-cd 🤗

@kapyaar
Copy link

kapyaar commented Oct 14, 2022

Is this fix as simple as updating the css file ? I updated the file on my machine, and restarted the IDE, but the issue still remains. Is there a recompile of some sort required?

@per1234
Copy link
Contributor

per1234 commented Oct 14, 2022

Hi @kapyaar. The fix is incorporated in the nightly build of the Arduino IDE. If you need the fix then please use the nightly build until the next release of Arduino IDE is made.

The download links for the nightly build are listed here:

https://www.arduino.cc/en/software/#nightly-builds

@kapyaar
Copy link

kapyaar commented Oct 14, 2022

@per1234 Gotcha, Installed and working great! such a relieve to see that last line without scrolling.Thanks!

@el-samiyel
Copy link

This was solved in 2.0.1 but back again in 2.0.2.

Not sure if its only limited to when the data present within the serial monitor requires the user to use the scroll bar to scroll right (it seems as if the scroll bar is covering up the last row of text).

@el-samiyel
Copy link

This was solved in 2.0.1 but back again in 2.0.2.

Not sure if its only limited to when the data present within the serial monitor requires the user to use the scroll bar to scroll right (it seems as if the scroll bar is covering up the last row of text).

Here is a snapshot:

sm

@per1234
Copy link
Contributor

per1234 commented Nov 21, 2022

Hi @el-samiyel. We are tracking this bug in a dedicated issue: #1602

@arduino arduino locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants