Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise the IDE updater even when 'checkForUpdates' preference is false #1490

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

AlbyIanna
Copy link
Contributor

Motivation

"Check for Arduino IDE Updates" operation fails when automatic update checks are disabled #1437

The reason is that we're avoiding to initialise the updater properly at start-up if the "Check for Arduino IDE Updates" preference is disabled.

Change description

Always initialise the updater. Only then we can decide if effectively check for updates or not.

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 26, 2022
@kittaakos kittaakos self-requested a review September 26, 2022 09:31
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants