fix: Handle gracefully when trying to detect invalid sketch name error and folder is missing on filesystem #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
added
topic: code
added 3 commits
November 2, 2022 16:38
gracefully handle when sketch folder has been deleted Closes #1596 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
The invalid sketch name detection requires at least one extra FS access. Do not try to detect invalid sketch name error, but use the original `NotFound` from the CLI. Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
AlbyIanna
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To fix missing
Open Recentmenu items in IDE2 when~/arduinoIDE/recent-sketches.jsoncontains non-existing sketches.Change description
The PR consists of three noteworthy changes:
ENOENT(No such file or directory) error when trying to detect if theNotFounderror received from the CLI is an "invalid sketch name" error. See: #964 Prompt move when opening invalid sketch outside from IDE2 #1563.ErrnoException(errno(3)) detection in IDE2.Open Recentmenus, it does not matter if the missing sketch was deleted or (incorrectly) renamed by the user. Hence the special error detection code does not run.Other information
Closes #1596
Reviewer checklist