Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: omit release details to speed up lib search #1949

Merged
merged 1 commit into from
Mar 16, 2023
Merged

feat: omit release details to speed up lib search #1949

merged 1 commit into from
Mar 16, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Mar 10, 2023 •
edited
Loading

Motivation

To speed up library search in IDE2 by omitting unnecessary information from the CLI via gRPC, such as the library release details.

Change description

Use the gRPC equivalent of the new --omit-releases-details flag for lib search.

Other information

The library manager works as in 2.0.4.

Ref: arduino/arduino-cli#2102

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 10, 2023
@kittaakos kittaakos self-assigned this Mar 10, 2023
per1234
per1234 approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

feat: omit release details to speed up lib search
f9c143f 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos merged commit 9b49712 into main Mar 16, 2023
@kittaakos kittaakos deleted the arduino/arduino-cli#2102 branch March 16, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @per1234