Allow leading underscore in sketch filenames #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
topic: code
|
Before relaxing the sketch folder and filename validation in this PR, IDE2 used Can IDE2 drop |
It's fine by me. That is actually what Arduino IDE 1.x does when you try to save a sketch with an invalid first character (it uses Shall I update the PR accordingly? |
If you agree with this change, doing it in this PR would be great. Thanks! |
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino IDE enforces compliance with the specification in order to ensure sketches created with Arduino IDE can be used with any other Arduino development tool. The Arduino Sketch Specification has been changed to allow a leading underscore in sketch folder names and sketch code filenames so IDE's sketch name validation must be updated accordingly.
per1234
force-pushed
the
allow_sketch_leading_underscore
branch
from
828bd87
to
a8ec75d
Compare
kittaakos
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Arduino Sketch Specification defines the allowed format of sketch folder names and sketch code filenames. Arduino IDE enforces compliance with the specification in order to ensure sketches created with Arduino IDE can be used with any other Arduino development tool.
The Arduino Sketch Specification is being changed to allow a leading underscore in sketch folder names and sketch code filenames:
arduino/arduino-cli#2105
Change description
Update Arduino IDE's sketch name validation according to the specification change.
Reviewer checklist