Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-focus monitor widget after verify/upload #1979

Merged
merged 1 commit into from
Mar 29, 2023
Merged

feat: re-focus monitor widget after verify/upload #1979

merged 1 commit into from
Mar 29, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

I find it inconvenient to switch back to the monitor widget after an upload. I implemented a super simple feature to re-focus the monitor widget after a verify/upload/upload using programmer/burn bootloader command.

Requirements:

  • the monitor widget is the current in the bottom panel. It does not necessarily have to have the focus, but when multiple tabs are open at the bottom, the monitor widget is on the top.
  • the command execution was successful. This task had no designs or requirements, but it's better to show the error output instead of re-focusing the monitor widget when the command has failed.

I am happy to tweak it to achieve something different behavior. We can also close this PR if not needed. I found it helpful.

In action:

refocus-monitor-widget.mp4

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

feat: re-focus monitor widget after verify/upload
2eed5bd 
supported when the monitor widget was the current in the bottom panel,
and the core command (upload/verify/etc./) was successful

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Mar 24, 2023
@kittaakos kittaakos self-assigned this Mar 24, 2023
@per1234 per1234 added the topic: serial monitor Related to the Serial Monitor label Mar 28, 2023
per1234
per1234 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit 6e72be1 into main Mar 29, 2023
@kittaakos kittaakos deleted the focus-monitor-after-upload branch March 29, 2023 08:02
@per1234 per1234 mentioned this pull request Mar 29, 2023
Closed
3 tasks
@intoku
Copy link

intoku commented Mar 29, 2023

Awesome, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself topic: serial monitor Related to the Serial Monitor type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @intoku @per1234