Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expand boards if available on detected port #2178

Merged
merged 2 commits into from
Aug 20, 2023
Merged

fix: expand boards if available on detected port #2178

merged 2 commits into from
Aug 20, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

When multiple boards are discovered on a detected port, the board selector component is broken in the firmware uploader dialog. This PR moves the board inference logic from the UI to the model and allows selecting a board+port pair even before confirming the board in the board list.

This PR pins the CLI version to 0.34.0-rc.1 to overcome the flaky tests mentioned at #2176 (comment).

Change description

Other information

I could reproduce the bug following the steps in #2175. I could fix the bug, but the firmware update fails at the CLI.

I connect my Arduino Nano RP2040 board and start the firmware update, and get all these board list watch logs and the stderr of the executable:

click to see the `board list watch` events and the error log from the firmware uploader CLI 

2023-08-19T11:00:06.494Z daemon INFO time="2023-08-19T13:00:06+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:00:06.495Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:00:09.447Z daemon INFO time="2023-08-19T13:00:09+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:00:09.448Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:00:19.617Z daemon INFO time="2023-08-19T13:00:19+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:00:19.620Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:00:19.780Z daemon INFO time="2023-08-19T13:00:19+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:00:19.780Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:00:27.686Z daemon INFO time="2023-08-19T13:00:27+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:00:27.687Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:00:30.072Z daemon INFO time="2023-08-19T13:00:30+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:00:30.074Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:00:40.351Z daemon INFO time="2023-08-19T13:00:40+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:00:40.352Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:00:40.527Z daemon INFO time="2023-08-19T13:00:40+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:00:40.528Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:00:48.596Z daemon INFO time="2023-08-19T13:00:48+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:00:48.597Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:00:50.622Z daemon INFO time="2023-08-19T13:00:50+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:00:50.624Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:01:00.878Z daemon INFO time="2023-08-19T13:01:00+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:01:00.879Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:01:01.449Z daemon INFO time="2023-08-19T13:01:01+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:01:01.450Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:01:09.530Z daemon INFO time="2023-08-19T13:01:09+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:01:09.531Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:01:11.134Z daemon INFO time="2023-08-19T13:01:11+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:01:11.135Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:01:22.414Z daemon INFO time="2023-08-19T13:01:22+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:01:22.415Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:01:23.403Z daemon INFO time="2023-08-19T13:01:23+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:01:23.403Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:01:30.490Z daemon INFO time="2023-08-19T13:01:30+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:01:30.491Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:01:33.695Z daemon INFO time="2023-08-19T13:01:33+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:01:33.696Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:01:43.307Z daemon INFO time="2023-08-19T13:01:43+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:01:43.308Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:01:43.991Z daemon INFO time="2023-08-19T13:01:43+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:01:43.992Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:01:51.393Z daemon INFO time="2023-08-19T13:01:51+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:01:51.394Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:01:54.256Z daemon INFO time="2023-08-19T13:01:54+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:01:54.257Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:02:04.251Z daemon INFO time="2023-08-19T13:02:04+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:02:04.252Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:02:04.545Z daemon INFO time="2023-08-19T13:02:04+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:02:04.546Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:02:12.344Z daemon INFO time="2023-08-19T13:02:12+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:02:12.345Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:02:14.816Z daemon INFO time="2023-08-19T13:02:14+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:02:14.817Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:02:25.122Z daemon INFO time="2023-08-19T13:02:25+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:02:25.123Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:02:25.214Z daemon INFO time="2023-08-19T13:02:25+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:02:25.217Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:02:33.339Z daemon INFO time="2023-08-19T13:02:33+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:02:33.340Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:02:35.398Z daemon INFO time="2023-08-19T13:02:35+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:02:35.399Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:02:45.713Z daemon INFO time="2023-08-19T13:02:45+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:02:45.714Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:02:46.175Z daemon INFO time="2023-08-19T13:02:46+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:02:46.176Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:02:54.264Z daemon INFO time="2023-08-19T13:02:54+02:00" level=info msg="from discovery builtin:serial-discovery received message type: remove, port: /dev/cu.usbmodem14301"
2023-08-19T11:02:54.265Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"/dev/cu.usbmodem14301","label":"","protocol":"serial","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:02:56.201Z daemon INFO time="2023-08-19T13:02:56+02:00" level=info msg="from discovery rp2040 received message type: add, port: UF2_Board"
2023-08-19T11:02:56.202Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"UF2 Board","protocol":"uf2conv","protocolLabel":"UF2 Devices","propertiesMap":[["mac","ffffffffffff"],["pid","0x2e8a"],["vid","0x000a"]],"hardwareId":""}},"error":""}
2023-08-19T11:03:06.535Z daemon INFO time="2023-08-19T13:03:06+02:00" level=info msg="from discovery rp2040 received message type: remove, port: UF2_Board"
2023-08-19T11:03:06.536Z discovery-log INFO {"eventType":"remove","port":{"matchingBoardsList":[],"port":{"address":"UF2_Board","label":"","protocol":"uf2conv","protocolLabel":"","propertiesMap":[],"hardwareId":""}},"error":""}
2023-08-19T11:03:07.117Z daemon INFO time="2023-08-19T13:03:07+02:00" level=info msg="from discovery builtin:serial-discovery received message type: add, port: /dev/cu.usbmodem14301"
2023-08-19T11:03:07.118Z discovery-log INFO {"eventType":"add","port":{"matchingBoardsList":[{"name":"Arduino Nano RP2040 Connect","fqbn":"arduino:mbed_nano:nanorp2040connect","isHidden":false},{"name":"Arduino Nano RP2040 Connect (dummy)","fqbn":"fwuploader-board-dummies:foo:nanorp2040connect","isHidden":false}],"port":{"address":"/dev/cu.usbmodem14301","label":"/dev/cu.usbmodem14301","protocol":"serial","protocolLabel":"Serial Port (USB)","propertiesMap":[["pid","0x005E"],["serialNumber","FFFFFFFFFFFFFFFF"],["vid","0x2341"]],"hardwareId":"FFFFFFFFFFFFFFFF"}},"error":""}
2023-08-19T11:03:13.705Z fwuploader ERROR Error: Error executing /Users/a.kitta/dev/git/arduino-ide/arduino-ide-extension/lib/node/resources/arduino-fwuploader firmware flash --fqbn arduino:mbed_nano:nanorp2040connect --address /dev/cu.usbmodem14301 --module NINA@1.5.0: Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
    at ChildProcess.<anonymous> (/Users/a.kitta/dev/git/arduino-ide/arduino-ide-extension/lib/node/exec-util.js:24:31)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess._handle.onexit (node:internal/child_process:291:12)
    at Process.callbackTrampoline (node:internal/async_hooks:130:17)
2023-08-19T11:03:13.706Z root ERROR Request flash failed with error: Error executing /Users/a.kitta/dev/git/arduino-ide/arduino-ide-extension/lib/node/resources/arduino-fwuploader firmware flash --fqbn arduino:mbed_nano:nanorp2040connect --address /dev/cu.usbmodem14301 --module NINA@1.5.0: Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab Error: Error executing /Users/a.kitta/dev/git/arduino-ide/arduino-ide-extension/lib/node/resources/arduino-fwuploader firmware flash --fqbn arduino:mbed_nano:nanorp2040connect --address /dev/cu.usbmodem14301 --module NINA@1.5.0: Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
Error: missing ack on erase: ab
    at ChildProcess.<anonymous> (/Users/a.kitta/dev/git/arduino-ide/arduino-ide-extension/lib/node/exec-util.js:24:31)
    at ChildProcess.emit (node:events:513:28)
    at ChildProcess._handle.onexit (node:internal/child_process:291:12)
    at Process.callbackTrampoline (node:internal/async_hooks:130:17)

Closes #2175

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Akos Kitta added 2 commits August 19, 2023 12:36
fix: expand boards if available on detected port
b4bf9f1 
moved the board inference logic from UI to  model

Closes #2175

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
chore(cli): pin version to 0.34.0-rc.1
46ffb04 
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos self-assigned this Aug 19, 2023
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project topic: CLI Related to Arduino CLI labels Aug 19, 2023
@kittaakos kittaakos mentioned this pull request Aug 19, 2023
Merged
4 tasks
per1234
per1234 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes both of the faults reported in #2175

Thanks Akos!

@kittaakos kittaakos merged commit 420d31f into main Aug 20, 2023
32 checks passed
@kittaakos kittaakos deleted the #2175 branch August 20, 2023 15:14
@kittaakos kittaakos mentioned this pull request Aug 20, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@davegarthsimpson davegarthsimpson Awaiting requested review from davegarthsimpson

Assignees

@kittaakos kittaakos

Labels
topic: CLI Related to Arduino CLI topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firmware Updater fails when target port has multiple identifications
2 participants
@kittaakos @per1234