Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing app icon for AppImage on Linux #2190

Merged
merged 2 commits into from
Aug 24, 2023
Merged

fix: missing app icon for AppImage on Linux #2190

merged 2 commits into from
Aug 24, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Aug 23, 2023

Motivation

Manually set the application icon for the AppImage on Linux.

Change description

The app icon is available from the AppImage on Linux.

Screenshot 2023-08-23 at 20 29 59

Other information

Closes #131

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Closes #131

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added type: enhancement Proposed improvement topic: code Related to content of the project itself os: linux Specific to Linux operating system labels Aug 23, 2023
@kittaakos kittaakos self-assigned this Aug 23, 2023
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos marked this pull request as ready for review August 23, 2023 18:31
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As can be seen in the screenshot shared in the PR message, the clear source icon is seriously degraded through the scaling down from the original 512x512 image

image

to 64x64:

Screenshot-3

It is even worse at my custom Settings > Appearance > Dock > Icon size setting of 16:

Screenshot-1

However, a visually low quality icon is a very significant improvement over no icon (as reported in #131 (comment) and which I experience on my Ubuntu 20.04 machine) or a generic fallback gear icon as I experience on my Ubuntu 22.04 machine. So I recommend this PR be merged as is rather than delay this important advancement in the pursuit of perfection. I am happy to create a follow up issue to track the task of finding a way to improve the quality of the displayed icon.

@kittaakos
Copy link
Contributor Author

he clear source icon is seriously degraded

I also noticed it 😕 I wanted to compare the UX with Theia Blueprint, but the icon is missing with the latest version: eclipse-theia/theia-ide#296.

a visually low quality icon is a very significant improvement over no icon

I agree.

I am happy to create a follow up issue to track the task of finding a way to improve the quality of the displayed icon.

Thank you!

@kittaakos kittaakos merged commit e08439b into main Aug 24, 2023
21 checks passed
@kittaakos kittaakos deleted the #131 branch August 24, 2023 15:04
@per1234
Copy link
Contributor

per1234 commented Aug 24, 2023

I have now submitted the follow-up issue to track the problem of the low visual quality of the icon: #2194

I wanted to compare the UX with Theia Blueprint

I got lucky and initially opened up an older version of Blueprint that I happened to have installed on my Linux machine so I was able to see the icon. It is also degraded, but the nature of the source image makes the degradation a bit less noticeable than it is on Arduino IDE's icon:

Screenshot-7

I was going to mention that in my review, but then I got confused when I downloaded the latest Blueprint and found it didn't have any icon at all (eclipse-theia/theia-ide#296).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: linux Specific to Linux operating system topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add application icon for Linux
2 participants