Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: defer board+port state update for extensions #2233

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix: defer board+port state update for extensions #2233

merged 1 commit into from
Sep 26, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Sep 21, 2023 •
edited
Loading

Motivation

To fix a race condition when setting the Arduin state for extensions at app startup. If the board+port state is set before it's read from the localStorage, clients will get an undefined fqbn.

Change description

Defer updating the board+port state for extensions when it's ready.

Other information

Ref: #2165
Ref: dankeboy36/esp-exception-decoder#10

Steps to reproduce:

  • you have an ESP32 board, the ESP32 platform and the debugger extension are installed.
  • create a new sketch,
  • attach the board, select the board and port, and save the sketch,
  • upload the sketch,
  • open the decoder terminal with the ESP Exception Decoder: Show Decoder Terminal command,
  • you see the FQBN and the sketch printed to the console,
  • quit IDE2,
  • start IDE2 and open the decoder terminal. You see the FQBN instead of the No board selected error message.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: defer board+port state update for extensions
94a51c2 
If it is set before the board+port settings are restored from the
`localStorage`, extensions will see no board+port.

Ref: #2165
Ref: dankeboy36/esp-exception-decoder#10

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 21, 2023
@kittaakos kittaakos self-assigned this Sep 21, 2023
@kittaakos kittaakos marked this pull request as ready for review September 22, 2023 09:03
per1234
per1234 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes dankeboy36/esp-exception-decoder#10. Thanks Akos!

@per1234 per1234 mentioned this pull request Sep 26, 2023
Closed
@kittaakos kittaakos merged commit 9f48296 into main Sep 26, 2023
21 checks passed
@kittaakos kittaakos deleted the set-state-after-board+port-restore branch September 26, 2023 07:56
@kittaakos kittaakos mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@kittaakos kittaakos

Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kittaakos @per1234