Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storage service injection #2241

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: storage service injection #2241

merged 1 commit into from
Sep 27, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Sep 27, 2023

Motivation

Store the board config data per sketch and not per IDE installation.

The (Theia) default StorageService implementation is workspace-scoped when @theia/workspace is part of the final application.

Change description

Changed the injection key to use the workspace-scoped storage service for the custom board options.

Other information

Closes #2240

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Sep 27, 2023
@kittaakos kittaakos requested a review from per1234 September 27, 2023 10:42
@kittaakos kittaakos self-assigned this Sep 27, 2023
Store the board config data per sketch and not per IDE installation.

The (Theia) default `StorageService` implementation is workspace-scoped
when `@theia/workspace` is part of the final application.

Closes #2240

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #2240.

Thanks Akos!

@kittaakos kittaakos merged commit ce02e26 into main Sep 27, 2023
21 checks passed
@kittaakos kittaakos deleted the #2240 branch September 27, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom board option selection made in one window affects other windows as well
2 participants