[ATL-1294] At first ide startup invoke installation of arduino:avr #497
Conversation
| protected invalidConfigPopup: | ||
| | Promise<void | 'No' | 'Yes' | undefined> | ||
| | undefined; | ||
| protected toDisposeOnStop = new DisposableCollection(); | ||
|
|
||
| @postConstruct() | ||
| protected async init(): Promise<void> { | ||
| const notFirstStartup = await this.localStorageService.getData( | ||
| 'notFirstStartup' |
There was a problem hiding this comment.
I'd use a const rather than just a string.
I'm also wondering if a more expressive string that relates to it's purpose is better
something like
const INIT_AVR_PACKAGES = 'initializedAvrPackages';
AlbyIanna
force-pushed
the
atl-1294--install-avr-first-startup
branch
from
c080392 to
90046c9
Compare
|
Maybe, Let user to choose installing the AVR core lib or not is better? |
@ShineUnM this PR is meant to close the gap between the IDE2 beta and the current IDE. The latter ships with AVR core pre-installed in order to make the experience as forgiving as possible for newcomers. I'll discuss your comment with the UX team and evaluate if we can find a suitable solution for more advanced users. Feel free to open an issue so that we can track your request and collect other feedback. thanks a lot |
per1234
added
topic: code
HOW
Use
LocalStorageServiceto know if it's the first IDE startup, and in that case launcharduino:avrinstallation.