Add dialog to insert user fields for board that require them to upload #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
force-pushed
the
scerza/upload-with-configuration
branch
from
276bf31 to
24f2ce7
Compare
silvanocerza
force-pushed
the
scerza/upload-with-configuration
branch
4 times, most recently
from
1e66d57 to
febf70a
Compare
silvanocerza
force-pushed
the
scerza/upload-with-configuration
branch
from
febf70a to
d744aa9
Compare
AlbyIanna
force-pushed
the
scerza/upload-with-configuration
branch
from
b245326 to
e5ab9b5
Compare
added 2 commits
November 24, 2021 16:55
AlbyIanna
force-pushed
the
scerza/upload-with-configuration
branch
from
e5ab9b5 to
a330d65
Compare
ubidefeo
approved these changes
Nov 25, 2021
This was referenced Sep 2, 2022
3 tasks
4 tasks
|
@silvanocerza Hello, thanks for contributing to the project but, can you please fix #1488 as you implemented this features that causes troubles to everyone trying to upload sketch via OTA on their ESP32 devices without password. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dialog for the user to enter custom fields necessary to upload to certain boards that require them.
If the user clicks the upload button on the toolbar and never upload to that board on that addres in the current IDE session the dialog will be shown, if all the fields are filled and the user clicks the Upload button the values will be cached for the current session. Subsequent uploads triggered with the upload button won't ask the user again to enter the fields but will use the cached ones.
If the user wants to change the fields after the first upload she must open the dialog from
Sketch > Configure And Uploadmenu, edit the fields and click the Upload button again.In any case clicking the Cancel button doesn't save the entered values.
User fields are not saved when closing the IDE.
Example:
upload.mp4