Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sketch name duplicates #887

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix sketch name duplicates #887

merged 1 commit into from
Mar 7, 2022

Conversation

AlbyIanna
Copy link
Contributor

Motivation

Newly created sketches share the same auto-generated name #593

Change description

Improve the function to generate the suffix of the sketch name.
Use a variable to count the number of sketches created today to prevent useless access to the file system

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@AlbyIanna AlbyIanna requested review from fstasi, ubidefeo and per1234 March 4, 2022 16:11
@per1234 per1234 added the topic: code Related to content of the project itself label Mar 6, 2022
per1234
per1234 approved these changes Mar 6, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves #593 for me.

I have missed this behavior, which I was accustomed to from Arduino IDE 1.x

Thanks Alberto!

@per1234 per1234 linked an issue Mar 6, 2022 that may be closed by this pull request
Newly created sketches share the same auto-generated name #593
Closed
fstasi
fstasi approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@fstasi fstasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

francescospissu
francescospissu approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build tested on Windows. It fixed the issue for me.

@AlbyIanna AlbyIanna merged commit 04c3d0c into main Mar 7, 2022
@AlbyIanna AlbyIanna deleted the fix-sketch-name-duplicates branch March 7, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescospissu francescospissu francescospissu approved these changes

@per1234 per1234 per1234 approved these changes

@fstasi fstasi fstasi approved these changes

@ubidefeo ubidefeo Awaiting requested review from ubidefeo

Assignees
No one assigned
Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newly created sketches share the same auto-generated name
4 participants
@AlbyIanna @fstasi @per1234 @francescospissu