-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit parallel jobs to 1 / use in-memeory pch storage #177
Conversation
@cmaglie, would you like me to create an IDE2 build for the verification with this LS? If yes, does this LS work with the Please update the PR description with links to the corresponding Don't we want to let users configure how many cores they wish to use for Thank you! |
No problem with that, I made the PR starting from the previous tagged version of the language server, and since I'm going to merge with a merge-commit I can make a release for both Arduino CLI 0.35.2 and 0.36.x.
Good point, I will add a flag to set the number of threads on this PR |
Released in The current |
Ref: arduino/arduino-language-server#177 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
chore: bump version for the release test: use the latest CLI version for testing feat(test): improve logging for tests - log when core install starts fix(test): regressions due to platform change - change core version to `3.0.0-arduino3r2`, - the vendor ID is `arduino` and not `esp32` anymore, and - use the AVR core for negative tests: it does not have a default programmer set. Hence, the expected error is no triggered. Ref: arduino/arduino-language-server#177 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Added a new preference (`arduino.language.asyncWorkers`) to control the number of async workers used by `clangd`. Users can use fine tune the `clangd` thread count to overcome excessive CPU usage. Ref: arduino/arduino-language-server#177 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
chore: bump version for the release test: use the latest CLI version for testing feat(test): improve logging for tests - log when core install starts fix(test): regressions due to platform change - change core version to `3.0.0-arduino3r2`, - the vendor ID is `arduino` and not `esp32` anymore, and - use the AVR core for negative tests: it does not have a default programmer set. Hence, the expected error is no triggered. Ref: arduino/arduino-language-server#177 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Added a new preference (`arduino.language.asyncWorkers`) to control the number of async workers used by `clangd`. Users can fine tune the `clangd` thread count to overcome the excessive CPU usage. Use 0.1.2 Arduino Tools VSIX in IDE2. Ref: arduino/arduino-language-server#177 Ref: arduino/vscode-arduino-tools#46 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Added a new preference (`arduino.language.asyncWorkers`) to control the number of async workers used by `clangd`. Users can fine tune the `clangd` thread count to overcome the excessive CPU usage. Use 0.1.2 Arduino Tools VSIX in IDE2. Ref: arduino/arduino-language-server#177 Ref: arduino/vscode-arduino-tools#46 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Please check if the PR fulfills these requirements
before creating one)
What kind of change does this PR introduce?
Limit the number of concurrent indexing jobs on
clangd
What is the current behavior?
The number of concurrent jobs equals the number of available CPU cores. This may lead to unusable systems in some cases...
What is the new behavior?
Limit the jobs to 1 core (2 threads if hyperthreaded).
Other information:
Fix #176 (already confirmed by @facchinm)