Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema-based rules for discovery dependencies data of package index #204

Merged
merged 2 commits into from
Jul 13, 2021
Merged

Add schema-based rules for discovery dependencies data of package index #204

merged 2 commits into from
Jul 13, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jul 13, 2021

These are the JSON schema-based rules to check the packages[].platforms[].discoveryDependencies[]-level data of the Arduino Package Index.

per1234 added 2 commits July 13, 2021 00:28
…ion` type

This test verifies that the package index JSON schema validation result for the type of
`Add missing test for packages[].platforms[].toolsDependencies[].version type` is as expected.
These are the JSON schema-based rules to check the `packages[].platforms[].discoveryDependencies[]`-level data of the
Arduino Package Index.
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 13, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #204 (1ee41db) into main (9c0f8c6) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   87.66%   87.86%   +0.19%     
==========================================
  Files          43       43              
  Lines        4079     4146      +67     
==========================================
+ Hits         3576     3643      +67     
  Misses        392      392              
  Partials      111      111              
Flag Coverage Δ
unit 87.86% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ternal/rule/ruleconfiguration/ruleconfiguration.go 100.00% <ø> (ø)
internal/rule/schema/schemadata/bindata.go 51.65% <ø> (ø)
internal/project/projectdata/packageindex.go 100.00% <100.00%> (ø)
internal/rule/rulefunction/packageindex.go 97.28% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0f8c6...1ee41db. Read the comment docs.

@per1234 per1234 merged commit 8277f9e into arduino:main Jul 13, 2021
@per1234 per1234 deleted the discoverydependencies-schema-rules branch July 13, 2021 12:56
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants