Implemented timeout on connect/getPrompt to handle board in strange s… #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate (crash). Signed-off-by: ubi de feo <me@ubidefeo.com>
|
Also tested on Ubuntu 22 and 24 LTS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the case of an unresponsive board which cannot produce a properly formatted prompt.
The timeout clearing has been pushed after the
await getPrompt()call in order to produce an alert for the user to reset the board.This will prevent the editor from locking up and requiring quit/reload with consequent loss of code.
Tested on Mac OS and Windows 11 in a Parallels VM.
More testing on Windows would be useful