-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump codecov/codecov-action from 3 to 4 #36
Bump codecov/codecov-action from 3 to 4 #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR resulted from an accidental tag push in the codecov/codecov-action
repository: codecov/codecov-action#1089
The tag has since been removed due to the v4 major version series of the action still being in the beta development phase. That removal will cause any subsequent runs of the workflow to fail:
Error: Unable to resolve action `codecov/codecov-action@v4`, unable to find version `v4`
So it must not be merged at this time. It will be merged once the v4
major version ref is created once more in the action repo following the production 4.0.0 release.
Note: The Codecov upload token is no longer optional in v4 of the action, so it will be necessary to also adjust the workflow to provide the token to the action at the same time as the bump. Doing so is a good idea anyway because, although supported in v3, the lack of a token was causing periodic spurious coverage data upload failures. That was done already in the Arduino CLI repo (arduino/arduino-cli#2129) and the approach used there has passed the test of time with flying colors.
The workflow does currently use the token
input of the action, but it uses the flawed approach of storing it in a secret, which would cause the workflow run to fail on any PR submitted from a fork after the action bump. So the workflow must be updated to use the system implemented in the Arduino CLI workflow.
@dependabot rebase |
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3...v4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
6ef6dbb
to
1737b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The codecov token has been added to the workflows.
The codecov token has been added to the workflows.
Bumps codecov/codecov-action from 3 to 4.
Release notes
Sourced from codecov/codecov-action's releases.
... (truncated)
Changelog
Sourced from codecov/codecov-action's changelog.
... (truncated)
Commits
c4cf8a4
4.0.0-beta.2 (#1086)845c445
not adding -n if empty to do-upload command (#1085)0016507
chore(release): 4.0.0-beta.1 (#1084)c9e4b73
use cli instead of node uploader (#1068)c9e0f0b
build(deps-dev): bump eslint from 8.48.0 to 8.49.0 (#1076)da8479a
build(deps-dev): bump@typescript-eslint/parser
from 6.6.0 to 6.7.0 (#1079)8e29a53
build(deps-dev): bump@types/node
from 20.5.9 to 20.6.0 (#1075)162bda9
build(deps): bump actions/upload-artifact from 3.1.2 to 3.1.3 (#1077)46acd9d
build(deps): bump actions/checkout from 3.6.0 to 4.0.0 (#1078)904bf5a
build(deps-dev): bump@typescript-eslint/eslint-plugin
from 6.6.0 to 6.7.0 (#...You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)