Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe noInterrupts disabling USB handshakes #891

Merged
merged 3 commits into from
Sep 3, 2022
Merged

Describe noInterrupts disabling USB handshakes #891

merged 3 commits into from
Sep 3, 2022

Conversation

beyarkay
Copy link
Contributor

See this SO question and answer

This change updates the docs to describe how disabling interrupts on the Arduino Nano 3.3v BLE will make the board not appear in the Ports tab, since this disables its ability to respond to USB handshakes.

@beyarkay
Copy link
Contributor Author

beyarkay commented Jul 2, 2022

Is anyone monitoring these pull requests?

per1234
per1234 requested changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this warning about one specific impact of noInterrupts out of the introductory description and to the more appropriate location in a "Notes and Warnings" section.

You can see how the section should be formatted here in the reference sample page:

https://github.com/arduino/reference-en/blob/master/AsciiDoc_sample/Reference_Terms/AsciiDoc_Template-Single_Entity.adoc?plain=1#L89

@per1234 per1234 self-assigned this Aug 12, 2022
@per1234 per1234 added the on hold The PR should not be merged at this time label Aug 12, 2022
@beyarkay
Copy link
Contributor Author

Sure thing!

@beyarkay
Copy link
Contributor Author

Hope that's better! Let me know if there's anything else I should change.

@beyarkay beyarkay requested a review from per1234 August 16, 2022 14:26
per1234
per1234 requested changes Sep 3, 2022
View reviewed changes
Language/Functions/Interrupts/noInterrupts.adoc Outdated Show resolved Hide resolved
Language/Functions/Interrupts/noInterrupts.adoc Outdated Show resolved Hide resolved
@beyarkay @per1234
Apply suggestions from code review
6dc42f9 
Co-authored-by: per1234 <accounts@perglass.com>
@per1234 per1234 removed the on hold The PR should not be merged at this time label Sep 3, 2022
per1234
per1234 approved these changes Sep 3, 2022
View reviewed changes
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this important enhancement to the reference @beyarkay!

@per1234 per1234 merged commit f6a8d7d into arduino:master Sep 3, 2022
@beyarkay beyarkay deleted the patch-1 branch September 3, 2022 19:09
@beyarkay
Copy link
Contributor Author

beyarkay commented Sep 3, 2022

No worries! Thanks for helping me through the process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees

@per1234 per1234

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beyarkay @per1234