Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix update go.mod and remove useless dependency #23

Merged
merged 1 commit into from
Jul 14, 2022
Merged

fix update go.mod and remove useless dependency #23

merged 1 commit into from
Jul 14, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Jul 13, 2022 •
edited
Loading

modify leftover on the go.mod and remove useless dependency, apparently this was never used 🤷‍♂️

@umbynos umbynos added the topic: code Related to content of the project itself label Jul 13, 2022
@umbynos umbynos requested review from per1234 and facchinm July 13, 2022 12:18
@umbynos umbynos self-assigned this Jul 13, 2022
per1234
per1234 reviewed Jul 13, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like clear evidence that a tidy module check should be added to the CI:

https://github.com/arduino/tooling-project-assets/blob/44f19512adf62659c71288f0c0cad6801aabdbea/workflow-templates/check-go-task.yml#L223-L228

@umbynos umbynos merged commit f22bd5b into master Jul 14, 2022
@umbynos umbynos deleted the fix branch July 14, 2022 15:29
@umbynos umbynos mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@facchinm facchinm Awaiting requested review from facchinm

Assignees

@umbynos umbynos

Labels
topic: code Related to content of the project itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@umbynos @per1234