-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the contributed ino
language and grammar, reuse it from the default VS Code C++ contibution
#43
Comments
My feeling is that, at least for the initial implementation, the ability to customize the grammar is not required. I don't see much value in the customization of vscode-arduino-tools/syntaxes/ino.tmGrammar.json Lines 134 to 137 in 6b9ee4b
However, in practice it seems they are highlighted as any other function: So if they were no longer included explicitly in the grammar after the migration to the new system, that would not actually be a regression. Nobody has complained about We have received reports about the lack of highlighting for other things: arduino/arduino-ide#380. I do think it would be nice if we could eventually customize the grammar to cover the fundamental Arduino core API keywords such as the ones mentioned in arduino/arduino-ide#380. So it would be worth investigating whether the new system has the capability to accommodate such customization. However, the current system does not cover them, so it would not be a regression if a new system didn't cover them either. |
|
Ref: arduino/vscode-arduino-tools#43 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
feat: semantic highlight
Due to the lack of workforce on this project, all grammar and language customizations should be avoided. Let's stick to the default C++ behavior from VS Code that is used by a large number of developers.
IDE2 users complain about the syntax highlighting (arduino/arduino-ide#2305), which seems to be a reasonable complaint; however, this is how syntax coloring works in VS Code, Eclipse Theia, GitHub, etc., and this project also provides the same behavior. There is no real reason for copying outdated grammar and syntax into this project.
Acceptance criteria:
loop
,setup
, etc.,vscode-grammar-updater
can be used.The text was updated successfully, but these errors were encountered: