Fix DDS238-2 wrong reactive power value (#12283)

arendst · Jun 20, 2021 · 0d18174 · 0d18174
1 parent 4c97948
commit 0d18174
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ All notable changes to this project will be documented in this file.
 
 ### Fixed
 - ESP32 Webcam add boundary marker before sending mjpeg image (#12376)
+- DDS238-2 wrong reactive power value (#12283)
 
 ## [Released]
 

diff --git a/RELEASENOTES.md b/RELEASENOTES.md
@@ -104,6 +104,7 @@ The latter links can be used for OTA upgrades too like ``OtaUrl http://ota.tasmo
 - Speed up initial GUI console refresh
 
 ### Fixed
+- DDS238-2 wrong reactive power value [#12283](https://github.com/arendst/Tasmota/issues/12283)
 - ESP32 Webcam add boundary marker before sending mjpeg image [#12376](https://github.com/arendst/Tasmota/issues/12376)
 
 ### Noted

diff --git a/tasmota/xnrg_09_dds2382.ino b/tasmota/xnrg_09_dds2382.ino
@@ -67,7 +67,7 @@ void Dds2382EverySecond(void)
       Energy.voltage[0] = (float)((buffer[27] << 8) + buffer[28]) / 10.0;
       Energy.current[0] = (float)((buffer[29] << 8) + buffer[30]) / 100.0;
       Energy.active_power[0] = (float)((buffer[31] << 8) + buffer[32]);
-      Energy.reactive_power[0] = (float)((buffer[33] << 8) + buffer[34]);
+      Energy.reactive_power[0] = (float)(int16_t)((buffer[33] << 8) + buffer[34]);
       Energy.power_factor[0] = (float)((buffer[35] << 8) + buffer[36]) / 1000.0;                                          // 1.00
       Energy.frequency[0] = (float)((buffer[37] << 8) + buffer[38]) / 100.0;                                              // 50.0 Hz
       uint8_t offset = 11;