Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant fading duration #10109

Closed
ghost opened this issue Dec 11, 2020 · 1 comment · Fixed by #10137
Closed

Constant fading duration #10109

ghost opened this issue Dec 11, 2020 · 1 comment · Fixed by #10137
Assignees
Labels
feature request (devs?) Action - awaiting response from developers work in progress Action - Work in progress

Comments

@ghost
Copy link

ghost commented Dec 11, 2020

Have you looked for this feature in other issues and in the docs?

Yes, I searched in the issues for a fixed fade duration, that takes always the same amount of time. I found #6942 but this was more related to gamma control.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.

I had an RGB controller in my bathroom. This is triggered by a motion sensor via Home Assistant. Generally the fading works smooth and nice in a time of about 2 seconds. But at the night I limited the maximum brightness to 20%. This is really cool because when I wake up late, it's not that blinding. But the disadvantage is that the duration of the fading is also just 20% of the time, when faded to 100%. This make it some kind of flashing because it reaches the maximum brightness within a really short time which can be really challenging for the eyes.

Describe the solution you'd like
A clear and concise description of what you want to happen.

It would be great if the fading is a constant time. Longer fade distances will be reached in the same amount of time as shorter distances.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

I also already enabled the gamma control, which makes the transition more linear for the physiological characteristics of the eyes but this didn't satisfy my needs.

Additional context
Add any other context or screenshots about the feature request here.

I checked out the code and looked for a nice place to put this functionality. I was neither able to build the code nor to test it. But I'd like to share the patch with you to present a possible solution.

constant_fade.txt

(Please, remember to close the issue when the problem has been addressed)

@ascillato2 ascillato2 added the feature request (devs?) Action - awaiting response from developers label Dec 12, 2020
@s-hadinger
Copy link
Collaborator

It was a debate whether the fading should be fixed duration or fixed slew rate. It was decided to be fixed slew rate, but it shouldn't be difficult to have a fixed duration as an alternative. I guess it means yet another SetOption?.

@s-hadinger s-hadinger self-assigned this Dec 14, 2020
@s-hadinger s-hadinger added the work in progress Action - Work in progress label Dec 14, 2020
s-hadinger added a commit to s-hadinger/Tasmota that referenced this issue Dec 14, 2020
s-hadinger added a commit that referenced this issue Dec 14, 2020
Command ``SetOption117 1`` for light fading to be fixed duration instead of fixed slew rate (#10109)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request (devs?) Action - awaiting response from developers work in progress Action - Work in progress
Projects
None yet
2 participants