-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telegram chat_id of incorrect size #11649
Labels
enhancement
Type - Enhancement that will be worked on
fixed
Result - The work on the issue has ended
Comments
I suggest you have a look at #9831 why this is an int32 now instead of a uint32. |
I think I'll move it to String anyway. Let me do some tests. |
arendst
added a commit
that referenced
this issue
Apr 10, 2021
Change telegram chatid from int32 to string (#11649)
arendst
added
enhancement
Type - Enhancement that will be worked on
fixed
Result - The work on the issue has ended
labels
Apr 10, 2021
Pls try and report back. |
Please, try the latest changes made by Theo. Thanks. |
1 task
I can now confirm that the modification is working perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Type - Enhancement that will be worked on
fixed
Result - The work on the issue has ended
PROBLEM DESCRIPTION
A clear and concise description of what the problem is.
Command tmsend fails when chat_id is greater than int32 (it is truncated to 32bits value)
REQUESTED INFORMATION
Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!
Backlog Template; Module; GPIO 255
:Backlog Rule1; Rule2; Rule3
:Status 0
:weblog
to 4 and then, when you experience your issue, provide the output of the Console log:TO REPRODUCE
Steps to reproduce the behavior:
Set bot token with tmtoken.
Set chat_id with tmchatid, with chat_id greater than 2147483648 (absolute value)
tmsend hello.
EXPECTED BEHAVIOUR
A clear and concise description of what you expected to happen.
Message sent.
SCREENSHOTS
If applicable, add screenshots to help explain your problem.
ADDITIONAL CONTEXT
Add any other context about the problem here.
The chat_id showed is always truncated to 2^31, although it is correctly stored, as can be seen with command tmchatid.
Changing the chat_id variable type from int32_t to String solves de problem. I will have a pull request if issue is confirmed.
(Please, remember to close the issue when the problem has been addressed)
The text was updated successfully, but these errors were encountered: