Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus: Always use prefix and update changelog #12842

Merged
merged 3 commits into from
Aug 9, 2021
Merged

Prometheus: Always use prefix and update changelog #12842

merged 3 commits into from
Aug 9, 2021

Conversation

hansmi
Copy link

@hansmi hansmi commented Aug 8, 2021

Description:

Implement TODOs to apply the tasmota_ prefix on all metrics and describe the changes from #12624 and #12692 in changelog.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
    • Compilation test only.
  • The code change is tested and works with Tasmota core ESP32 V.1.0.7
    • Compilation test only.
  • I accept the CLA.

hansmi and others added 3 commits August 8, 2021 17:21
@hansmi
prometheus: Add prefix on all metrics
990ae38 
All Prometheus metrics should have an application prefix
(https://prometheus.io/docs/practices/naming/#metric-names).
Historically a few produced by Tasmota didn't. With this change the
function writing metrics always outputs the prefix.

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
@hansmi
Describe recent changes to Prometheus metrics in changelog
7afc194 
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
@arendst
Merge branch 'development' into promchg1
229a8cb
@arendst arendst merged commit b43779c into arendst:development Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hansmi @arendst