Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus: Fix typos, improve documentation, expose device name #12624

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Prometheus: Fix typos, improve documentation, expose device name #12624

merged 3 commits into from
Jul 13, 2021

Conversation

hansmi
Copy link

@hansmi hansmi commented Jul 11, 2021 •
edited
Loading

Description:

Fix a couple of typos and add a link to Prometheus exposition format, then add the device name setting to the tasmota_info metric.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
    • Please note that this PR contains multiple commits, each of which addresses a single topic.
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
    • Sonoff TH16
  • The code change is tested and works with Tasmota core ESP32 V.1.0.7
    • (compilation test only)
  • I accept the CLA.

hansmi added 3 commits July 11, 2021 20:16
@hansmi
prometheus: Fix typos in comments
56ed94d 
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
@hansmi
prometheus: Add comment with link to exposition format
9e44163 
Signed-off-by: Michael Hanselmann <public@hansmi.ch>
@hansmi
prometheus: Expose device name as part of device info
16b5f2f 
The device name can be useful to identify a particular instance in
Prometheus.

Example:

```
tasmota_info{...,devicename="livingroom"} 1
```

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
@arendst arendst merged commit 3712aba into arendst:development Jul 13, 2021
@hansmi hansmi deleted the prometheusdevicename1 branch August 8, 2021 14:54
@hansmi hansmi mentioned this pull request Aug 8, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hansmi @arendst