POLL: While using different locale keep JSON text in English #1473
Labels
help needed
Action - Asking for help from the community
Comments
|
I definitely agree with separation between web interface labels and JSON attributes name; I'm in doubt on how to handle JSON attributes in messages not related to telemetry like results of MQTT commands... |
|
translations are for human interaction, Language choice for the GUI should never change the over-the-wire API |
|
I agree, programmatic interfaces should be language neutral. But, UI should be localized to the user's preference. |
|
Agree. Modern English has no artifacts, and is common choice. I vote for English |
|
Agree. JSON in English, UI localised...... |
|
I believe also that this is the right way to absract the code level from the UI level. |
|
it also seems, that the iobroker cannot read things like "Current" if the german firmware is used. |
arendst
added a commit
that referenced
this issue
Jan 6, 2018
5.10.0j * Allow conditional code based on core version * Removed all MQTT, JSON and Command language defines from locale files (#1473)
arendst
added a commit
that referenced
this issue
Jan 7, 2018
5.11.0 20180107 * Minor webpage HTML optimizations (#1358) * Updated German translation (#1438) * Change Sonoff Pow Energy MQTT data message and consolidate Status 8 into Status 10 * Change ADS1115 default voltage range from +/-2V to +/-6V (#1289) * Change text to Active for 3 minutes (#1364) * Change Wemo SetBinaryState to distinguish from GetBinaryState (#1357) * Change output of HTTP command to valid JSON and Array only (#1363) * Removed all MQTT, JSON and Command language defines from locale files and set fixed to English (#1473) * Renamed commands Color2,3,4 to Color3,4,5 * Fix BME280 calculation (#1051) * Fix Sonoff Bridge missed learned key if learned data contains 0x55 (End of Transmission) flag (#1095, #1294) * Fix PWM initialization in Dimmer/Color mode (#1321) * Fix Wemo Emulation (#1357) * Fix display of build date and time in non-english locale (#1465) * Fix Wemo and Hue emulation by adding M-Search response delay (#1486) * Add libraries Adafruit_BME680-1.0.5, Adafruit_Sensor-1.0.2.02, TasmotaSerial-1.0.0 and TSL2561-Arduino-Library * Add command Color2 to set color while keeping same dimmer value * Add device function pointers * Add support for SenseAir S8 CO2 sensor * Add color led signal to Carbon Dioxide (CO2) sensors using defines CO2_LOW and CO2_HIGH in user_config.h * Add support for Domoticz Air Quality sensor to be used by MH-Z19(B) and SenseAir sensors * Add support for PZEM004T energy sensor * Add support for iTead SI7021 temperature and humidity sensor by consolidating DHT22 into AM2301 and using former DHT22 as SI7021 (#735) * Add support for BME680 using adafruit libraries (#1212) * Add support for MH-Z19(B) CO2 sensor (#561, #1248) * Add multipress support and more user configurable GPIO to Sonoff Dual R2 (#1291) * Add support for TSL2561 using adafruit library (#661, #1311) * Add support for SHT3x (#1314) * Add support for Arilux LC06 (#1414) * Add Italian language file (#1449) * Add 2nd Gen Alexa support to Wemo emulation discovery (#1357, #1450) * Add define for additional number of WS2812 schemes (#1463)
joecotton
pushed a commit
to joecotton/Sonoff-Tasmota
that referenced
this issue
Jan 8, 2018
5.11.0 20180107 * Minor webpage HTML optimizations (arendst#1358) * Updated German translation (arendst#1438) * Change Sonoff Pow Energy MQTT data message and consolidate Status 8 into Status 10 * Change ADS1115 default voltage range from +/-2V to +/-6V (arendst#1289) * Change text to Active for 3 minutes (arendst#1364) * Change Wemo SetBinaryState to distinguish from GetBinaryState (arendst#1357) * Change output of HTTP command to valid JSON and Array only (arendst#1363) * Removed all MQTT, JSON and Command language defines from locale files and set fixed to English (arendst#1473) * Renamed commands Color2,3,4 to Color3,4,5 * Fix BME280 calculation (arendst#1051) * Fix Sonoff Bridge missed learned key if learned data contains 0x55 (End of Transmission) flag (arendst#1095, arendst#1294) * Fix PWM initialization in Dimmer/Color mode (arendst#1321) * Fix Wemo Emulation (arendst#1357) * Fix display of build date and time in non-english locale (arendst#1465) * Fix Wemo and Hue emulation by adding M-Search response delay (arendst#1486) * Add libraries Adafruit_BME680-1.0.5, Adafruit_Sensor-1.0.2.02, TasmotaSerial-1.0.0 and TSL2561-Arduino-Library * Add command Color2 to set color while keeping same dimmer value * Add device function pointers * Add support for SenseAir S8 CO2 sensor * Add color led signal to Carbon Dioxide (CO2) sensors using defines CO2_LOW and CO2_HIGH in user_config.h * Add support for Domoticz Air Quality sensor to be used by MH-Z19(B) and SenseAir sensors * Add support for PZEM004T energy sensor * Add support for iTead SI7021 temperature and humidity sensor by consolidating DHT22 into AM2301 and using former DHT22 as SI7021 (arendst#735) * Add support for BME680 using adafruit libraries (arendst#1212) * Add support for MH-Z19(B) CO2 sensor (arendst#561, arendst#1248) * Add multipress support and more user configurable GPIO to Sonoff Dual R2 (arendst#1291) * Add support for TSL2561 using adafruit library (arendst#661, arendst#1311) * Add support for SHT3x (arendst#1314) * Add support for Arilux LC06 (arendst#1414) * Add Italian language file (arendst#1449) * Add 2nd Gen Alexa support to Wemo emulation discovery (arendst#1357, arendst#1450) * Add define for additional number of WS2812 schemes (arendst#1463)
|
old but still: should be the state in the json response (e.g. status 0) changed by statetext if we look at this poll/ticket? is it possible to send normal on/off per json/status 0 and changed statetexts only to mqtt ? TasmoAdmin/TasmoAdmin#154 (comment) BR |
curzon01
pushed a commit
to curzon01/Tasmota
that referenced
this issue
Sep 6, 2018
5.10.0j * Allow conditional code based on core version * Removed all MQTT, JSON and Command language defines from locale files (arendst#1473)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From version 5.10.0e I provide the means to keep the JSON text messages in a different language from the locales.
In the locales DE, NL and PL the JSON text is indeed translated but seems to amount to problems with JSON users like node-red not being able to handle German umlauts for instance.
I propose to keep JSON text in English for ALL locales and therefore want to change the DE, NL and PL locales.
So if anyone in favor of English will add his thumb to this issue I will change within the next week.
If there are any doubts please add to this issue and explain. There is always to possibility to provide both languages using a define in the language file but I prefer not to take that road...
EDIT: POLL CLOSED. The overall agreement is to NOT translate JSON messages so I will remove the current JSON specific translations and consolidate these in the i18n.h file. Thnx for your input.
The text was updated successfully, but these errors were encountered: