Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonoff LED #16

Closed
jaysuk opened this issue Feb 2, 2017 · 8 comments
Closed

Sonoff LED #16

jaysuk opened this issue Feb 2, 2017 · 8 comments
Labels
enhancement Type - Enhancement that will be worked on

Comments

@jaysuk
Copy link

jaysuk commented Feb 2, 2017

I don't seem to be able to adjust the brightness of the LED's.
Currently, they are not as bright as a sonoff LED with the default firmware

@arendst
Copy link
Owner

arendst commented Feb 3, 2017

Still waiting for mine to arrive...

@arendst arendst added the enhancement Type - Enhancement that will be worked on label Feb 3, 2017
@ecsfang
Copy link

ecsfang commented Feb 4, 2017

Hi, just received my Sonoff LED. Not tested to much yet (loaded with Theo's latest), but power on/off works, as well as Dimmer 0-100. But I have noticed that the leds blink shortly (quick power off on) when I change the dimmer value.
I also had a problem with the led-bars, half of them was wrongly mounted, there is a plastic cover with arrow indication of polarity, but in half of mine, the cover was backwards, so make a check and check the indication on the actual flex (the are arrows in both ends there as well).
Cheers,
Thomas

@ecsfang
Copy link

ecsfang commented Feb 5, 2017

Hi again!

Did some more simple testing after uploading 3.9.11. The "Dimmer" command only works for the "cold" led, in my case, the "warm" led is always at about 50%, but both can be turned on or off. The led-strip contains two different leds, which has its own output, one "cold" white and one "warm" white.
Nor is the code stable yet: every now and then the leds blinks shortly (while being powered on).
So, I guess that we just have to wait for Theo's devices to arrive :)

Best regards,
Thomas

@arendst
Copy link
Owner

arendst commented Feb 5, 2017

Does a dimmer2 command do anything to the warm led?

@ecsfang
Copy link

ecsfang commented Feb 5, 2017

Hi! Yes, Dimmer2 handles the warm led, thanks - I missed that one! :)
But still, when power on - i.e. Leds are turned on, the leds randomly powers off and on.

@arendst
Copy link
Owner

arendst commented Feb 18, 2017

For those interested: I received my Sonoff Led and fixed the low dimmer values; it appears the default analogWrite range is from 0 to 1023. I fixed that so the full range of light is available. Currently working on:

  • one color command for both leds like a normal RGB led strip
  • one dimmer command for both leds like a normal RGB led strip

The flickering is caused by the config save routine which disables interrupts while updating the flash. Temporary workaround is changing the config save time from the default 1 second to say 60 seconds with command savedata 60.

To be continued...

@ecsfang
Copy link

ecsfang commented Feb 18, 2017

Sounds great - thanks for your findings!
I have not yet seen a schematic of this device, but I will try to find out if any GPIOs are available for e.g. an external switch.

arendst added a commit that referenced this issue Feb 18, 2017
3.9.18 20170218
* Fix ledstate 0 to turn off led
* Fix Sonoff Led dimmer range (#16)
* Change Sonoff Led command Dimmer to act on both cold and warm color
* Add Sonoff Led command Color CCWW where CCWW are hexadecimal values
fro 00 - FF
* Reduce Sonoff Led flickering by disabling interrupts during flash save
and disabling
*   Led during OTA upgrade and Web upload (#16)
@ecsfang
Copy link

ecsfang commented Feb 18, 2017

A quick look shows that GPIO 4, 5 and 15 are easily accessible (reserved for RGB?). So with some small modifications these should be available for other use. I will try to add an external push-button switch to be able to turn the leds on/off with a smooth transition. I already have the wirings for an old lamp in the kitchen which I want to replace, but still use the physical switch to turn them on/off.

@arendst arendst closed this as completed Mar 8, 2017
ascillato added a commit that referenced this issue Jun 5, 2018
curzon01 pushed a commit to curzon01/Tasmota that referenced this issue Sep 6, 2018
3.9.18 20170218
* Fix ledstate 0 to turn off led
* Fix Sonoff Led dimmer range (arendst#16)
* Change Sonoff Led command Dimmer to act on both cold and warm color
* Add Sonoff Led command Color CCWW where CCWW are hexadecimal values
fro 00 - FF
* Reduce Sonoff Led flickering by disabling interrupts during flash save
and disabling
*   Led during OTA upgrade and Web upload (arendst#16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type - Enhancement that will be worked on
Projects
None yet
Development

No branches or pull requests

3 participants