Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade feature causes flash writes #7262

Closed
TimelessNL opened this issue Dec 19, 2019 · 4 comments · Fixed by #7266
Closed

Fade feature causes flash writes #7262

TimelessNL opened this issue Dec 19, 2019 · 4 comments · Fixed by #7266
Labels
duplicated Result - Duplicated Issue

Comments

@TimelessNL
Copy link

PROBLEM DESCRIPTION

With all flash save options turned OFF and fade turned ON any RGB change is still written to Flash.

REQUESTED INFORMATION

  • ✅ Read the Contributing Guide and Policy and the Code of Conduct
  • ✅ Searched the problem in issues
  • ✅ Searched the problem in the docs
  • ✅ Searched the problem in the forum
  • ✅ Searched the problem in the chat
  • ✅ Device used (e.g., Sonoff Basic): Any devices with at least 1 PWM channel
  • ✅ Tasmota binary firmware version number used: 7.1.2
    • ⛔️ Pre-compiled
    • ✅ Self-compiled
      • ✅ IDE / Compiler used: ArduinoIDE SDK 2.6.1
  • ✅ Flashing tools used: Web OTA
  • ✅ Provide the output of command: Backlog Template; Module; GPIO 255:
00:18:37 CMD: Backlog Template; Module; GPIO 255
00:18:37 RSL: RESULT = {"NAME":"LSC RGBW LED","GPIO":[0,255,0,255,0,0,0,0,181,0,180,0,0],"FLAG":15,"BASE":18}
00:18:38 RSL: RESULT = {"Module":{"0":"LSC RGBW LED"}}
00:18:38 RSL: RESULT = {"GPIO0":{"0":"Geen"},"GPIO1":{"0":"Geen"},"GPIO2":{"0":"Geen"},"GPIO3":{"0":"Geen"},"GPIO4":{"0":"Geen"},"GPIO5":{"0":"Geen"},"GPIO9":{"0":"Geen"},"GPIO10":{"0":"Geen"},"GPIO12":{"181":"SM2135 Dat"},"GPIO13":{"0":"Geen"},"GPIO14":{"180":"SM2135 Clk"},"GPIO15":{"0":"Geen"},"GPIO16":{"0":"Geen"}}
00:18:38 RSL: STATE = {"Time":"2019-12-20T00:18:38","Uptime":"0T00:00:11","UptimeSec":11,"Vcc":3.512,"Heap":28,"SleepMode":"Dynamic","Sleep":50,"LoadAvg":19,"MqttCount":0,"POWER":"OFF","Dimmer":28,"Color":"0000001647","HSBColor":"0,0,0","Channel":[0,0,0,9,28],"CT":419,"Scheme":0,"Fade":"ON","Speed":10,"LedTable":"ON","Wifi":{"AP":1,"SSId":"HIDDEN","BSSId":"HIDDEN","Channel":9,"RSSI":82,"LinkCount":1,"Downtime":"0T00:00:06"}}
  • ⛔️ If using rules, provide the output of this command: Backlog Rule1; Rule2; Rule3:
  • ⛔️ Provide the output of this command: Status 0:
  • ⛔️ Provide the output of the Console log output when you experience your issue; if applicable:

TO REPRODUCE

  1. Flash Tasmota 7.1.2
  2. Command reset 5
  3. Command backlog poweronstate 1; savedata0; setoption0 0; restart 1;
  4. Change the RGB colors and see that there are no new flash writes.
  5. Command backlog fade 1; speed 10; restart 1
  6. Change the RGB colors and see that there are new flash writes.

EXPECTED BEHAVIOUR

If setoption0 0 and savedata 0 are set no flash writes should occur.

SCREENSHOTS

N/A

ADDITIONAL CONTEXT

I prefer to keep smart-lights functional for ordinary light switches, so when they are turned off by cutting the power they should return to their pre-saved RGBW value the next time they are turned on. Basically when the light is turned on it can be controlled thought MQTT but when the power is cut it should restore to it's normal light intensity the next time it's turned on by reapplying power.

@ascillato
Copy link
Contributor

Already solved. Please update to the latest Tasmota in the development branch (thehackbox.org/tasmota/tasmota.bin) Thanks.

@ascillato2 ascillato2 added the duplicated Result - Duplicated Issue label Dec 20, 2019
@s-hadinger
Copy link
Collaborator

I would rephrase to "soon to be solved" instead of "already solved".

s-hadinger pushed a commit to s-hadinger/Tasmota that referenced this issue Dec 20, 2019
arendst added a commit that referenced this issue Dec 20, 2019
Fix Fade would ignore ``savedata 0`` and store to flash anyways (#7262)
@s-hadinger
Copy link
Collaborator

Now solved. Thanks for reporting.

@TimelessNL
Copy link
Author

Nice work. Thanks!

marius pushed a commit to marius/Tasmota that referenced this issue Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicated Result - Duplicated Issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants