Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for LCD 2004A 20x4 #8062

Closed
tthk opened this issue Apr 4, 2020 · 1 comment
Closed

Better support for LCD 2004A 20x4 #8062

tthk opened this issue Apr 4, 2020 · 1 comment
Labels
question Type - Asking for Information

Comments

@tthk
Copy link
Contributor

tthk commented Apr 4, 2020

Have you looked for this feature in other issues and in the docs?
Yes

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is.
LCD display support is currently on for 16x2 characters display. Please support 2004A I2C display, which is 20x4.

Describe the solution you'd like
A clear and concise description of what you want to happen.
Changes to remove 16x2 hardcoded display resolution and allow user to select 20x4.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
LCD 2004 can be used, but because Tasmota initialized it as 16x2, the formatting is off.

Additional context
Add any other context or screenshots about the feature request here.
I've made a change in two files which allows 20x4 sized LCD. I am submitting a pull request and will reference this issue.
A feature request for this exact issue was closed a while back:
#669

(Please, remember to close the issue when the problem has been addressed)

tthk added a commit to tthk/Tasmota that referenced this issue Apr 4, 2020
@ascillato2 ascillato2 added the feature request (devs?) Action - awaiting response from developers label Apr 4, 2020
@ascillato2
Copy link
Collaborator

ascillato2 commented Apr 4, 2020

Closing as the thread continues in #8064

@ascillato2 ascillato2 added question Type - Asking for Information and removed feature request (devs?) Action - awaiting response from developers labels Apr 4, 2020
tthk added a commit to tthk/Tasmota that referenced this issue Apr 10, 2020
This reverts commit f1ed412.

Revert to remove unwanted commit, bringing back to match upstream HEAD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Type - Asking for Information
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants