Improve color light integration with HomeAssistant for so19 1 #12659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves the way color lights are discovered by Home Assistant with
SetOption19 = 1
:Lights with color support (RGB, RGBW, RGBWW)
Home Assistant will be using HS color instead of RGB color. This is a better fit because Home Assistant requires the RGB color to be absolute, whereas Tasmota scales the RGB color with brightness.
4-channel lights (RGBW)
Home Assistant 2021.7 introduces color mode
white
.This is a good fit for Tasmota 4 channel lights which don't support independent control of all 4 channels.
4-channel lights will be discovered as supporting
hs
andwhite
, but not both at the same time.5-channel lights (RGBW)
5-channel lights will be discovered as supporting
hs
andcolor_temp
, but not both at the same time.Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass