Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve color light integration with HomeAssistant for so19 1 #12659

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Jul 15, 2021

Description:

This PR improves the way color lights are discovered by Home Assistant with SetOption19 = 1:

Lights with color support (RGB, RGBW, RGBWW)

Home Assistant will be using HS color instead of RGB color. This is a better fit because Home Assistant requires the RGB color to be absolute, whereas Tasmota scales the RGB color with brightness.

4-channel lights (RGBW)

Home Assistant 2021.7 introduces color mode white.
This is a good fit for Tasmota 4 channel lights which don't support independent control of all 4 channels.

4-channel lights will be discovered as supporting hs and white, but not both at the same time.

5-channel lights (RGBW)

5-channel lights will be discovered as supporting hs and color_temp, but not both at the same time.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.4.9
  • The code change is tested and works with Tasmota core ESP32 V.1.0.7.1
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@emontnemery emontnemery marked this pull request as draft July 15, 2021 14:24
@emontnemery emontnemery changed the title Improve RGBW light integration with HomeAssistant for so19 1 Improve color light integration with HomeAssistant for so19 1 Jul 15, 2021
@arendst arendst marked this pull request as ready for review July 16, 2021 11:40
@arendst arendst merged commit 3d7c109 into arendst:development Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants